From owner-svn-src-all@freebsd.org Thu Jan 14 09:46:16 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41866A80098 for ; Thu, 14 Jan 2016 09:46:16 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D599D116D for ; Thu, 14 Jan 2016 09:46:15 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x231.google.com with SMTP id f206so419300309wmf.0 for ; Thu, 14 Jan 2016 01:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=eIwBR28lDYcB+FV0fc2NYn8w3wQT1r3VlgDTEyKTsz8=; b=Tv9A/euF12JMTNswLiFVPkih3xvg/Z5ZZvAn3erY/EJPMStxryLwmHX8qMamy1rpt+ iCp0yipw2xeKipga5WJq7unU3HHitag4QF5ZfSCz0G1BwzTV6xY0VacKugzpLOr7NNXh meQ+ybCAzRPmlpzSpzt4O6XeXz0lum4s5PhVvdc79DEcLSLND0knF5duunTo+B54lwty UyIN0D1BBK3I+4Ygpyizvo8ykLpm7OVYqKJ+vulntIbzgCbXveDnThpDwmlsHez59oSt olfaLgcM350mqZOQu8U/O8fe+j8sn3rmiL20a+EaNVsCooRu9aKiT3gLOiwHDHNz5Uqd gvdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=eIwBR28lDYcB+FV0fc2NYn8w3wQT1r3VlgDTEyKTsz8=; b=TPW1LFWs6ciZECrJYsl+sXyOZ5h40bWoBZowCsIZ3PllXFqGKsO7M+anwYTal1Q7G6 nQimnTk+W0w0AhPoHleb2Hxx/ZBHN6THvvxv4SxDmkIjATOpSPphJVssdcL9qSPXgNM4 SDlPXe+lZmVaGp2jD7+bfB/I+scGrESjJ5ynGAW0MdwS9aoeNkmX5A6T1QH1Nqg/f89m ofWzWSIP096TyXrMdg7/NKKYV3t4nZ/dKwg7dAWfS/tgEsrfViwif4yLsr4FqyZ/lfbs 5aUQJvcn5DloEaCShyKd+M66ZzZIv5dcSt8hv5jPtvnS04FZkCWT3ndhouRIikgr4vIG wWYQ== X-Gm-Message-State: AG10YOTAA3xvdKbfn3v8ofESTLbNZ7xvZFmXKk2R8pWl9edMwlnG2aGjVHibt2o+e64tq/YG X-Received: by 10.194.188.100 with SMTP id fz4mr862243wjc.126.1452764773361; Thu, 14 Jan 2016 01:46:13 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id z127sm26105926wme.2.2016.01.14.01.46.11 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 01:46:12 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi To: NGie Cooper References: <201601140922.u0E9M1rV025146@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <56976E76.3000604@freebsd.org> Date: Thu, 14 Jan 2016 09:46:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 09:46:16 -0000 On 14/01/2016 09:27, NGie Cooper wrote: >> On Jan 14, 2016, at 01:22, Steven Hartland wrote: >> >> Author: smh >> Date: Thu Jan 14 09:22:01 2016 >> New Revision: 293903 >> URL: https://svnweb.freebsd.org/changeset/base/293903 >> >> Log: >> Fix GCC warnings causing build failure after r293724 >> >> Disable some compiler warnings for GCC (non-standard compiler) fixing >> build failures introduced by r293724, which enabled WARNS in the EFI boot >> code, when compiling with none standard compiler (GCC). > Disabling warnings is wrong. Here’s how arm could be fixed: > > $ svn diff sys/boot/ > Index: sys/boot/common/bootstrap.h > =================================================================== > --- sys/boot/common/bootstrap.h (revision 293877) > +++ sys/boot/common/bootstrap.h (working copy) > @@ -32,6 +32,7 @@ > #include > #include > #include > +#include > > /* > * Generic device specifier; architecture-dependant > @@ -332,12 +333,8 @@ > extern struct arch_switch archsw; > > /* This must be provided by the MD code, but should it be in the archsw? */ > -void delay(int delay); > - > void dev_cleanup(void); > > -time_t time(time_t *tloc); > - > #ifndef CTASSERT /* Allow lint to override */ > #define CTASSERT(x) _CTASSERT(x, __LINE__) > #define _CTASSERT(x, y) __CTASSERT(x, y) > Index: sys/boot/efi/include/efiapi.h > =================================================================== > --- sys/boot/efi/include/efiapi.h (revision 293877) > +++ sys/boot/efi/include/efiapi.h (working copy) > @@ -532,6 +532,7 @@ > typedef > EFI_STATUS > (EFIAPI *EFI_RESERVED_SERVICE) ( > + VOID > ); > > typedef > > amd64 is a bit trickier: > > /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/efigop.h:75: warning: 'ms_abi' attribute directive ignored > > I didn’t dig into why this is happening [yet], other than there maybe being MS extensions involved? > Thanks for that Garret, as Ian confirmed this change fixed his immediate issue I went with it, after confirming with a full GCC tinderbox of course. I agree your changes are more correct, however I don't have an build resource ATM, so if you have time / resources to confirm they work correctly with a full CLANG and GCC tinderbox please feel LMK and I'll get it committed :) If you don't get chance before the end of the week, I'll have build resource available and will look to test then, hope this is OK? Regards Steve