Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Oct 2024 16:13:59 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 282386] emulators/dosbox-x: fix build with libc++ 19
Message-ID:  <bug-282386-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282386

            Bug ID: 282386
           Summary: emulators/dosbox-x: fix build with libc++ 19
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: eduardo@FreeBSD.org
          Reporter: dim@FreeBSD.org
          Assignee: eduardo@FreeBSD.org
             Flags: maintainer-feedback?(eduardo@FreeBSD.org)

As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes emulators/dosbox-x to fail to compile with clang 19 and
libc++ 19, resulting in errors similar to:

  /usr/include/c++/v1/string:820:42: error: implicit instantiation of undef=
ined
template 'std::char_traits<unsigned short>'
    820 |   static_assert(is_same<_CharT, typename
traits_type::char_type>::value,
        |                                          ^
  dos_programs.cpp:7692:17: note: in instantiation of template class
'std::basic_string<unsigned short>' requested here
   7692 |     test_string dst;
        |                 ^
  /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^
  dos_programs.cpp:8893:14: warning: variable 'open' set but not used
[-Wunused-but-set-variable]
   8893 |         bool open=3Dfalse;
        |              ^

This can be fixed by using char16_t for the 'test_char_t` type, and by
adding a few inline wrappers to perform the required casting.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-282386-7788>