From owner-freebsd-bugs@freebsd.org Fri Mar 16 00:46:04 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16C27F632AE for ; Fri, 16 Mar 2018 00:46:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A9B018260E for ; Fri, 16 Mar 2018 00:46:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 0101218B3C for ; Fri, 16 Mar 2018 00:46:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w2G0k2XU006051 for ; Fri, 16 Mar 2018 00:46:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w2G0k2VO006050 for freebsd-bugs@FreeBSD.org; Fri, 16 Mar 2018 00:46:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 226650] ESXi NFSv4.1 client complains that "2" isn't a valid reason for not issuing a delegation Date: Fri, 16 Mar 2018 00:46:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 00:46:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226650 Bug ID: 226650 Summary: ESXi NFSv4.1 client complains that "2" isn't a valid reason for not issuing a delegation Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: rmacklem@FreeBSD.org Created attachment 191541 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D191541&action= =3Dedit Change the reasons for not issuing delegations to ones that the ESXi client= is happy with The ESXi NFSv4.1 client logs warning messages that state "2" is not a valid reason for not issuing a delegation. "2" is the RESOURCE one and I don't see why it wouldn't be a valid reason. However, since other NFSv4.1 clients don't seem to care, changing the NFSv4.1 server to not use this reason for the default case of delegations not being enabled seems reasonable. Unfortunately RFC5661 doesn't define a default reason, so I selected FTYPE_NOT_SUPP as the closest and the ESXi client doesn't complain about this one. The attached patch changes the NFSv4.1 server to reply with reasons for not issuing delegations that seems to make the ESXi client happy. (The FreeBSD NFSv4.1 client ignores the reasons, so it doesn't care what they are. Testing with the Linux client is still needed for this patch to ensure it doesn't cause problems with the Linux client. If that is the case, I believe it should be ok to commit to head and MFC.) --=20 You are receiving this mail because: You are the assignee for the bug.=