From nobody Wed Oct 5 13:04:21 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MjFKn49Sbz4fCMf; Wed, 5 Oct 2022 13:10:05 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from sprint-2.amdmi3.ru (sprint-2.amdmi3.ru [185.185.68.145]) by mx1.freebsd.org (Postfix) with ESMTP id 4MjFKl3qgHz3Sq1; Wed, 5 Oct 2022 13:10:03 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from amdmi3.ru (localhost [127.0.0.1]) by sprint-2.amdmi3.ru (Postfix) with SMTP id C3657187E67; Wed, 5 Oct 2022 16:10:57 +0300 (MSK) Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000 amdmi3@amdmi3.ru; Wed, 5 Oct 2022 16:10:57 +0300 (MSK) Date: Wed, 5 Oct 2022 16:04:21 +0300 From: Dmitry Marakasov To: Piotr Kubaj Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c698371b0910 - main - devel/sdl20: fix armv7-related check in SDL_atomic.h Message-ID: References: <202209291355.28TDt7Ln090671@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202209291355.28TDt7Ln090671@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4MjFKl3qgHz3Sq1 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of amdmi3@amdmi3.ru has no SPF policy when checking 185.185.68.145) smtp.mailfrom=amdmi3@amdmi3.ru X-Spamd-Result: default: False [-1.99 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.994]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; R_SPF_NA(0.00)[no SPF record]; ARC_NA(0.00)[]; DMARC_NA(0.00)[amdmi3.ru]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[amdmi3]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:35278, ipnet:185.185.68.0/22, country:RU] X-ThisMailContainsUnwantedMimeParts: N * Piotr Kubaj (pkubaj@FreeBSD.org) wrote: > URL: https://cgit.FreeBSD.org/ports/commit/?id=c698371b0910e792db5690126bde955456fdccd2 > > commit c698371b0910e792db5690126bde955456fdccd2 > Author: Piotr Kubaj > AuthorDate: 2022-09-29 13:51:25 +0000 > Commit: Piotr Kubaj > CommitDate: 2022-09-29 13:54:40 +0000 > > devel/sdl20: fix armv7-related check in SDL_atomic.h > > Fixes build errors like: > In file included from /usr/ports/games/openrct2/work/OpenRCT2-0.4.1/src/openrct2-ui/CursorRepository.h:12: In file included from /usr/local/include/SDL2/SDL.h:35: /usr/local/include/SDL2/SDL_atomic.h:243:28: error: '__ARM_ARCH__' is not defined, evaluates to 0 [-Werror,-Wundef] #elif (defined(__arm__) && __ARM_ARCH__ >= 7) || defined(__aarch64__) > --- > devel/sdl20/Makefile | 4 ++++ > devel/sdl20/distinfo | 4 +++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/devel/sdl20/Makefile b/devel/sdl20/Makefile > index d84a9679030b..6e8c2c390ba6 100644 > --- a/devel/sdl20/Makefile > +++ b/devel/sdl20/Makefile > @@ -1,9 +1,13 @@ > PORTNAME= sdl2 > DISTVERSION= 2.24.0 > +PORTREVISION= 1 > CATEGORIES= devel > MASTER_SITES= https://www.libsdl.org/release/ > DISTNAME= SDL2-${PORTVERSION} > > +PATCH_SITES= https://github.com/libsdl-org/SDL/commit/ > +PATCHFILES= a204ef50bbf20b77083c0a14124e673efc3a53c6.patch:-p1 I think I've already asked, but I'm not sure it was you. Please do not ever introduce this kind of unmaintainable ugliness to my ports. All patches should be put under files/. > MAINTAINER= amdmi3@FreeBSD.org > COMMENT= Cross-platform multimedia development API > WWW= https://www.libsdl.org/ > diff --git a/devel/sdl20/distinfo b/devel/sdl20/distinfo > index 3f836d60852a..c78d82f18d9c 100644 > --- a/devel/sdl20/distinfo > +++ b/devel/sdl20/distinfo > @@ -1,3 +1,5 @@ > -TIMESTAMP = 1661880729 > +TIMESTAMP = 1664457277 > SHA256 (SDL2-2.24.0.tar.gz) = 91e4c34b1768f92d399b078e171448c6af18cafda743987ed2064a28954d6d97 > SIZE (SDL2-2.24.0.tar.gz) = 7520541 > +SHA256 (a204ef50bbf20b77083c0a14124e673efc3a53c6.patch) = 2cc9607f42acc8b00ac058cbc5fcba3d7037db21db679533afd483824dd5b658 > +SIZE (a204ef50bbf20b77083c0a14124e673efc3a53c6.patch) = 1168 > -- Dmitry Marakasov . amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/