From owner-cvs-all Mon Dec 18 14:42:13 2000 From owner-cvs-all@FreeBSD.ORG Mon Dec 18 14:42:09 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mail.interware.hu (mail.interware.hu [195.70.32.130]) by hub.freebsd.org (Postfix) with ESMTP id 2EA7537B402; Mon, 18 Dec 2000 14:42:08 -0800 (PST) Received: from marakesh-16.budapest.interware.hu ([195.70.50.144] helo=elischer.org) by mail.interware.hu with esmtp (Exim 3.16 #1 (Debian)) id 1488ys-00070e-00; Mon, 18 Dec 2000 23:42:06 +0100 Sender: julian@FreeBSD.ORG Message-ID: <3A3E928F.76607FA1@elischer.org> Date: Mon, 18 Dec 2000 14:41:19 -0800 From: Julian Elischer X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en, hu MIME-Version: 1.0 To: Warner Losh Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples/drivers make_device_driver.sh References: <200012182108.eBIL8sj42300@freefall.freebsd.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Thanks! having a sample to point people at really helps so I really apreciate the time you took to do this.. Warner Losh wrote: > > imp 2000/12/18 13:08:54 PST > > Modified files: > share/examples/drivers make_device_driver.sh > Log: > o Add cardbus support (use pci attachment for now) > > o Add comments in some places to clarify some points. > o Don't typedef sc_p. This isn't usually done in the drivers and may > cause problems in teh future if C goes the C++ route of requiring > one and only one definition for each and every type. Instead use > the current convetion of expanding struct ${1}_softc * inline needed. > o change some comments to be more style(9)-like. > o Define and use DEV2SOFTC to encapsulate storing/getting softc from a > dev_t. This also takes care of the missing cast from the examples. > o Define and use DEVICE2SOFTC, similar to DEV2SOFTC for getting the > softc from a device_t. > > > We still should have this generate foo_{isa,pci,pccard,cardbus,eisa}.c > and foovar.h from templates of some sort, but I was too lazy to do > that in this commit. I did document it in the comments, however. > > Note: bde-like corrections made with the help of my my portable > plastic bde icon. Results with the real bde may vary with use. > > Revision Changes Path > 1.16 +82 -44 src/share/examples/drivers/make_device_driver.sh -- __--_|\ Julian Elischer / \ julian@elischer.org ( OZ ) World tour 2000 ---> X_.---._/ presently in: Budapest v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message