From owner-cvs-ports@FreeBSD.ORG Mon Nov 14 11:21:57 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65FF3106564A; Mon, 14 Nov 2011 11:21:57 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id DABCC8FC12; Mon, 14 Nov 2011 11:21:56 +0000 (UTC) Received: by ywe9 with SMTP id 9so3341415ywe.13 for ; Mon, 14 Nov 2011 03:21:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=6buRvMKta9A57npWCIXdKh5UFN37J/k46ZZJ7OThIfs=; b=QuNYjkMZtc/uc3U2Q+/e89QKtXbcyTiEsXvEpzVIcCNt1bz7jSvcZis+iWP8CwzwDr HZRkyf4wrBuEncnSBjUtJz3PQg/zzJThGQ9pWmXxvioM4hMEyv0k69U4CHRHA3rSzocm cuoOr1B1ORpcPpFz1wlr6NtuQ+foNVa2O/ptg= MIME-Version: 1.0 Received: by 10.50.158.227 with SMTP id wx3mr22626289igb.52.1321269713899; Mon, 14 Nov 2011 03:21:53 -0800 (PST) Sender: utisoft@gmail.com Received: by 10.231.11.140 with HTTP; Mon, 14 Nov 2011 03:21:53 -0800 (PST) Received: by 10.231.11.140 with HTTP; Mon, 14 Nov 2011 03:21:53 -0800 (PST) In-Reply-To: <20111114110809.GC2888@azathoth.lan> References: <201111130956.pAD9u85M053975@repoman.freebsd.org> <20111114110809.GC2888@azathoth.lan> Date: Mon, 14 Nov 2011 11:21:53 +0000 X-Google-Sender-Auth: t7eBQs4nhx2zSOfEJ3n4jf6v9wQ Message-ID: From: Chris Rees To: Baptiste Daroussin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, Ed Schouten , cvs-all@freebsd.org, matthew@cashdollar.org Subject: Re: cvs commit: ports/shells/zsh/files patch-Src_watch.c X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2011 11:21:57 -0000 On 14 Nov 2011 11:09, "Baptiste Daroussin" wrote: > > On Sun, Nov 13, 2011 at 10:45:35AM +0000, Chris Rees wrote: > > On 13 November 2011 09:56, Baptiste Daroussin wrote: > > > bapt 2011-11-13 09:56:08 UTC > > > > > > FreeBSD ports repository > > > > > > Added files: > > > shells/zsh/files patch-Src_watch.c > > > Log: > > > - Fix build for badly upgraded systems which have both utmp.h and utmpx.h > > > > > > PR: ports/156263 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=156263 > > > Submitted by: Matthew Cashdollar > > > Feature safe: yes > > > > > > > Fixing it here will only mask the problem-- why are we adding a fix to > > support a broken system? > > > > The proper solution is to rm utmp.h in that system, is it not? > > > > I suggest a different patch at [1]. > > > > Chris > > > > [1] http://www.bayofrum.net/~crees/patches/zsh-utmpx-fix.diff.txt > > [removing the patchfile too] > > Well no I don't think, or you would have to add the same patch in lots of ports. > > In fact, I have been pondering for long what would be the best fix for this. And > if I need to provide a fix. > Given that some people can use zsh for root (as I do :)) I think being able to > rebuild zsh a clean way before doing the make delete-old is nice, that is why I > did a fix that way. I understand where you're coming from, but I would also like to point out that make delete-old doesn't remove any libs; it's safe to run with old ports around. I would still be inclined to blame this on the docs; I'm working on a patch right now. In the meantime, make delete-old should be run before rebuilding. Chris