Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 May 2013 06:24:44 GMT
From:      Norihiko Murase <mur1080224@inter7.jp>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/178525: sysutils/less: correct the build option
Message-ID:  <201305120624.r4C6Oi2L056719@oldred.FreeBSD.org>
Resent-Message-ID: <201305120630.r4C6U1ig013654@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         178525
>Category:       ports
>Synopsis:       sysutils/less: correct the build option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 12 06:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Norihiko Murase
>Release:        
>Organization:
>Environment:
>Description:
Hey! Quick fix, please.

I would like you to fix the bug related to the build option 
that resides in the port sysutils/less. This bug did slip 
into this port at SVN Revision 317890 (related PR: ports/178261)
for the port update (451->458).

Well, the bug is (probably) simple; the line
  .if ${PORT_OPTIONS:MCOLOUR_LESS}
should be
  .if ${PORT_OPTIONS:MCOLOR_LESS}
because the option named "COLOR_LESS" (NOT COLO*U*R_LESS) is 
defined as follows:
  OPTIONS_DEFINE=        COLOR_LESS
  COLOR_LESS_DESC=Enables color support via escape sequence

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -U 11 -r less_317890/Makefile less_cur/Makefile
--- less_317890/Makefile	2013-05-12 14:35:43.000000000 +0900
+++ less_cur/Makefile	2013-05-12 14:38:54.000000000 +0900
@@ -15,19 +15,19 @@
 
 OPTIONS_DEFINE=	COLOR_LESS
 COLOR_LESS_DESC=Enables color support via escape sequence
 
 PLIST_FILES=	bin/less bin/lesskey bin/lessecho
 
 .include <bsd.port.options.mk>
 
 GNU_CONFIGURE=	yes
 MAN1=		less.1 lesskey.1 lessecho.1
 
-.if ${PORT_OPTIONS:MCOLOUR_LESS}
+.if ${PORT_OPTIONS:MCOLOR_LESS}
 CPPFLAGS+=	-DCOLOR_LESS
 
 pre-fetch:
 	@${ECHO_MSG} "Making a color version of less."
 .endif
 
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305120624.r4C6Oi2L056719>