Date: Mon, 03 Feb 2025 14:42:33 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Doug Moore <dougm@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ee511f83b386 - main - vm_reserv: use default pool for free page removal. Message-ID: <20250203224233.72223189@slippy.cwsent.com> In-Reply-To: <202502032158.513LwUI8015476@gitrepo.freebsd.org> References: <202502032158.513LwUI8015476@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <202502032158.513LwUI8015476@gitrepo.freebsd.org>, Doug Moore writes : > The branch main has been updated by dougm: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ee511f83b386299d9ad0b4e7b141eed1 > 28eddf2b > > commit ee511f83b386299d9ad0b4e7b141eed128eddf2b > Author: Doug Moore <dougm@FreeBSD.org> > AuthorDate: 2025-02-03 21:56:34 +0000 > Commit: Doug Moore <dougm@FreeBSD.org> > CommitDate: 2025-02-03 21:58:17 +0000 > > vm_reserv: use default pool for free page removal. > > Differential Revision: https://reviews.freebsd.org/D45409 Your description in the revision is an excellent description. Too bad it wasn't in the commit log. The summary in the revision tells us why. > --- > sys/vm/vm_reserv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/vm/vm_reserv.c b/sys/vm/vm_reserv.c > index 04453e050a38..1102cb61323a 100644 > --- a/sys/vm/vm_reserv.c > +++ b/sys/vm/vm_reserv.c > @@ -480,7 +480,8 @@ vm_reserv_depopulate(vm_reserv_t rv, int index) > if (rv->popcnt == 0) { > vm_reserv_remove(rv); > vm_domain_free_lock(vmd); > - vm_phys_free_pages(rv->pages, rv->pages->pool, VM_LEVEL_0_ORDER > ); > + vm_phys_free_pages(rv->pages, VM_FREEPOOL_DEFAULT, > + VM_LEVEL_0_ORDER); > vm_domain_free_unlock(vmd); > counter_u64_add(vm_reserv_freed, 1); > } > -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e^(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20250203224233.72223189>