From owner-freebsd-hackers@FreeBSD.ORG Mon Jul 16 10:57:41 2012 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 241DD106564A; Mon, 16 Jul 2012 10:57:41 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from mail.kirov.so-ups.ru (ns.kirov.so-ups.ru [178.74.170.1]) by mx1.freebsd.org (Postfix) with ESMTP id 86D168FC0A; Mon, 16 Jul 2012 10:57:40 +0000 (UTC) Received: from kas30pipe.localhost (localhost.kirov.so-ups.ru [127.0.0.1]) by mail.kirov.so-ups.ru (Postfix) with SMTP id 36DB0B8027; Mon, 16 Jul 2012 14:57:39 +0400 (MSK) Received: from kirov.so-ups.ru (unknown [172.21.81.1]) by mail.kirov.so-ups.ru (Postfix) with ESMTP id 18A56B8026; Mon, 16 Jul 2012 14:57:39 +0400 (MSK) Received: by ns.kirov.so-ups.ru (Postfix, from userid 1010) id 13B88BA07F; Mon, 16 Jul 2012 14:57:39 +0400 (MSK) Received: from [127.0.0.1] (unknown [10.118.3.52]) by ns.kirov.so-ups.ru (Postfix) with ESMTP id CFFE4BA07A; Mon, 16 Jul 2012 14:57:38 +0400 (MSK) Message-ID: <5003F39D.6030808@FreeBSD.org> Date: Mon, 16 Jul 2012 14:57:33 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231) MIME-Version: 1.0 To: Andriy Gapon References: <4FE9B01C.30306@yandex.ru> <5003EBAB.6030507@FreeBSD.org> In-Reply-To: <5003EBAB.6030507@FreeBSD.org> X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF2E5F3064C6DDEFA89A2B846" X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0284], KAS30/Release X-SpamTest-Info: Not protected Cc: freebsd-hackers , Marius Strobl , freebsd-current , Pawel Jakub Dawidek Subject: Re: [CFC/CFT] large changes in the loader(8) code X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2012 10:57:41 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF2E5F3064C6DDEFA89A2B846 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 16.07.2012 14:23, Andriy Gapon wrote: > on 26/06/2012 15:50 Andrey V. Elsukov said the following: >> 3. ZFS code now uses new API and probing on the systems with many disk= s >> should be greatly increased: >> zfs/zfs.c >> i386/loader/main.c >=20 > First of all, it's hard to parse the above sentence. "probing ... shoul= d be > greatly increased". Probing what? :-) If probing time, then we don't = want that ;-) >=20 > I looked through the ZFS-related part and here are a few comments: Thanks for that. > 1. I think that the predominant indentation style of i386/loader/main.c= should be > preserved for consistency. >=20 > 2. I am not sure if I like the approach of moving partition tasting cod= e into > common ZFS code (zfs.c). On one hand, it now makes sense because the n= ew > partition iteration code is machine-independent. On the other hand, th= e reason > that I added arch_zfs_probe method was to give platforms full control o= ver which > partitions and in what order are probed. It seems to be important for = some of them. > So, I like how your new partition interface makes it much easier to ZFS= -probe > partitions, but I would prefer to have that code in arch_zfs_probe impl= ementations > rather than in zfs_probe_dev. =46rom the other point of view, ZFS is not a just file system and it work= s directly with disks and partitions. And it seems to me this code will be = common for other architectures. > 3. Related to the above. In what shape is sparc64 ZFS support in your= branch? > Have you tried to adapt it to the new model too? > It's the platform that has special requirements for disk/partition prob= ing order. > Marius can help with additional information and testing here. Currently i have not received any feedback reports from the users who can= test patches on the other architectures. I added VTOC8 support to the part.c, = but it seems it is not needed and ofw can work without this. --=20 WBR, Andrey V. Elsukov --------------enigF2E5F3064C6DDEFA89A2B846 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJQA/OiAAoJEAHF6gQQyKF6REAH/A2waKFDxiljXNm+liofAd9Q GaIpYj+jNAIKMHHMLIdY2vM5HTQ61wIMHD7d83/uUekhBCAb/tqhhGelZn224O9j bHGPhW+YY36RVf2qs7QzX+ldSuHWq3B8MXzh5zzy71Znd4XzPfPudRqIynHLE5Jj 04OQNWjIgvTQqOJxIZwIT03vnKICRo2DWPWtxY0njMklBVoNfDMhyLwW2UBGjXfF sx4qks45aL+hc+uuZTJoRf/RwWRDk2srs9LtYAWr6B2Mez6JbyaOR5FwUmYNmDK1 7/AAF621+QFxZHlcUsrPW2hxugIBB49/6IkHEfxP19Oap8cj5edUucP1zxqI4B4= =80zQ -----END PGP SIGNATURE----- --------------enigF2E5F3064C6DDEFA89A2B846--