From owner-cvs-all@FreeBSD.ORG  Mon Mar 17 04:01:47 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6A9E8106564A;
	Mon, 17 Mar 2008 04:01:47 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from sippysoft.com (gk1.360sip.com [72.236.70.240])
	by mx1.freebsd.org (Postfix) with ESMTP id 3E4A18FC16;
	Mon, 17 Mar 2008 04:01:47 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from [192.168.0.36] ([204.244.149.125]) (authenticated bits=0)
	by sippysoft.com (8.13.8/8.13.8) with ESMTP id m2H41jsM079959
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 16 Mar 2008 21:01:45 -0700 (PDT)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <47DDED1F.8000707@FreeBSD.org>
Date: Sun, 16 Mar 2008 21:01:35 -0700
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Sippy Software, Inc.
User-Agent: Thunderbird 2.0.0.12 (Windows/20080213)
MIME-Version: 1.0
To: Robert Watson <rwatson@FreeBSD.org>
References: <200803160621.m2G6LUlE034766@repoman.freebsd.org>
	<20080316100836.F44049@fledge.watson.org>
In-Reply-To: <20080316100836.F44049@fledge.watson.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys eventhandler.h src/sys/kern
 kern_descrip.c uipc_socket.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Mar 2008 04:01:47 -0000

Robert Watson wrote:
> On Sun, 16 Mar 2008, Maxim Sobolev wrote:
> 
>> sobomax     2008-03-16 06:21:30 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/sys              eventhandler.h
>>    sys/kern             kern_descrip.c uipc_socket.c
>>  Log:
>>  Properly set size of the file_zone to match kern.maxfiles parameter.
>>  Otherwise the parameter is no-op, since zone by default limits number
>>  of descriptors to some 12K entries. Attempt to allocate more ends up
>>  sleeping on zonelimit.
> 
> Hmm.  Could you be more specific about the nature of the problem you're 
> seeing here?  UMA shouldn't impose any default zone limit on the 
> file_zone if none is set.  Are you sure it's the struct file zonelimit 
> you're running into, and not, say, the socket zone limit, etc?

Yes, you are right, further investigation revealed that in my case I was 
hitting maxsockets limit, not maxfiles limit. Not sure if the backout is 
in order or having files zone limit has some value, so that possible 
leaks can be detected and UMA zone can potentially do size-based 
optimizations in the future?

> Also, don't use SI_SUB_EVENTHANDLER+1 -- add a new event type, perhaps 
> SI_SUB_FILE, or use SI_ORDER_LAST.

OK, what about maxsockets code? Should it be changed to?

-Maxim