From owner-freebsd-hackers@freebsd.org Sat Dec 22 06:45:22 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34C2913477FB for ; Sat, 22 Dec 2018 06:45:22 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D070073376 for ; Sat, 22 Dec 2018 06:45:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 6CCF31CAC1 for ; Sat, 22 Dec 2018 06:45:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f178.google.com with SMTP id v1-v6so6613549ljd.0 for ; Fri, 21 Dec 2018 22:45:21 -0800 (PST) X-Gm-Message-State: AJcUukf6yuS67ZBP9wYx+oyj8GZ6KWjPLcpJbY6U8lM9dfPtyb/Ustr4 G0rV7R3z/SfyChDQ0+iabAYkyGqfkQFS7Z4WGto= X-Google-Smtp-Source: ALg8bN4kVFCUIjcL+LhX2o2+xViR/7f0wEieMD2kDGDPE6pXSYbEYcVDnjE+15qGPsRP9/kTN3YoaUdNkNAiNFS01JQ= X-Received: by 2002:a2e:a202:: with SMTP id h2-v6mr3245163ljm.72.1545461119647; Fri, 21 Dec 2018 22:45:19 -0800 (PST) MIME-Version: 1.0 References: <20181222064138.GM60291@kib.kiev.ua> In-Reply-To: <20181222064138.GM60291@kib.kiev.ua> From: Kyle Evans Date: Sat, 22 Dec 2018 00:45:08 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: is adding new private symbols to libc frowned upon? To: Konstantin Belousov Cc: Yuri Pankov , freebsd-hackers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D070073376 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Dec 2018 06:45:22 -0000 On Sat, Dec 22, 2018 at 12:42 AM Konstantin Belousov wrote: > > On Sat, Dec 22, 2018 at 04:38:52AM +0300, Yuri Pankov wrote: > > Essentially, I need the __collate_equiv_value symbol to be visible to > > libregex for the changes in https://reviews.freebsd.org/D18531. Is the > > following change OK (it works, at least), or should try to avoid that? > > > > --- a/lib/libc/locale/Symbol.map > > +++ b/lib/libc/locale/Symbol.map > > @@ -212,6 +212,7 @@ FBSD_1.3 { > > FBSDprivate_1.0 { > > _PathLocale; > > __detect_path_locale; > > + __collate_equiv_value; > > __collate_load_error; > > __collate_range_cmp; > > }; > > > Then libregex must always match the installed libc. > > I looked at the the libregex/Makefile and my question is, what is the > difference between exports from libc/regex vs. libregex. Can libregex > become ELF filter for libc ? > libregex is going to be getting more complicated [1] after a couple more exp-runs. I can possibly re-work it to make a filter work (perhaps?), but I'm not sure how badly that will impact the performance of libc regex. [1] https://reviews.freebsd.org/D12935