From nobody Sat Oct 11 10:17:31 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ckKL35qWTz6BbJN; Sat, 11 Oct 2025 10:17:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ckKL35LzZz3Yft; Sat, 11 Oct 2025 10:17:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760177851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q0cpqa03OmdPYdK2jQgmDwxjNWWJw4Ce1CNP9V85CBY=; b=dTPXA3ghXfDpG/I2X1sD2zIUinsDaB1RY6X11A/oLD169+lM0C4cPE+TUPVPRwgbqc/+4o f+OFqc25XFUg4vLL8qOMF842NvGbS0yidvaP1HU032siBAFPLa8E7mFC2XYsr0rrxG02Xz 8+ZxdxjeZjGMUfMON/BsXk/awnY9zWWsNblyEPT36/3UaAlIXXWSg5KFV/afgMKdlSHy4b +ziU4fIFERPWKmrK6WQv/oH6NR2YvAtQhzQ0Ey26eQUqmL8NLX4yurVNdLNEUuvYy0lUjm bWh71CbCnP78zgOoqjlAF+lMzOLb7Ax3iiOyKU+tKfuSsIWPHiLBvVvZcurPbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760177851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q0cpqa03OmdPYdK2jQgmDwxjNWWJw4Ce1CNP9V85CBY=; b=tsegYekfkO0/gx22imRQPRMRLzxtBnIjoy/Ag8kcf81TC4druhxreNQwtNrqgZ8EAoWOoz mlQpji3iCDpu3RHavKQcRnoScRyjCXf7JkTDNjxxS7pEkVTKobgLudRryHilu2u/DTD6S7 K07nxWSWU4cGLGPvwNYTPiT/ggn9BS9A/Wb2Wj6h0MOCRrjlpk5q8zson/gg3RurQZulXJ LFnG2rMpuLXtl4CKhFAYaDbdQIa2KEn/gCGJgcRJHVsW+vJcLCTQI5rKRRYNTebc4qG6v4 K51XH8tluqimmph3pNd+6D27By8vZlR29e871tO4SGPgV0EUgMM940YZqmesIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760177851; a=rsa-sha256; cv=none; b=mmEw1K1ZlYcw4G3hJQM0fG//uTEBic2glZg8RgVi8yBD33NWCfPpiw8Id/t79bZhhrmrSK U/cfk7F/UJxK5renVGMR0ybakugIduuCZi9NjCyr/UBGU9ZRuH1AsMsVy8UwlW2KlWW+e+ 0knX4ze9+te9raMJbsqKl0hH+YqvimPKqyLN2irn6G3LPXk6kWt5g6F7qPdVERFeMM31Bs UvHM246fa+/79WXDTMhKv/C0CqdHa2UIsaTBaiW5G55yR3D+aBTsrdTAvQeV3UZzJiSCQi GfF1tzAUnr5V2jnMuyTB6fFMd59CnPn9agt/95bCzAxpgTLBdOTWPvxcTasO2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ckKL34vNCzDNN; Sat, 11 Oct 2025 10:17:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59BAHVP5033798; Sat, 11 Oct 2025 10:17:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59BAHVtD033795; Sat, 11 Oct 2025 10:17:31 GMT (envelope-from git) Date: Sat, 11 Oct 2025 10:17:31 GMT Message-Id: <202510111017.59BAHVtD033795@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 25cca51ed294 - main - libm: remainder: make sure x is zero List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 25cca51ed294890d20a3c0290814cd26875db686 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=25cca51ed294890d20a3c0290814cd26875db686 commit 25cca51ed294890d20a3c0290814cd26875db686 Author: Ahmad Khalifa AuthorDate: 2025-10-10 09:30:52 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-11 10:13:19 +0000 libm: remainder: make sure x is zero Make sure the entirety of x is zero before flipping the sign bit. Otherwise the sign would be wrong for small values of x when x is negative and |n*y| > |x| Reported by: alfredo PR: 251091 Reviewed by: kargl MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D53023 --- lib/msun/src/e_remainder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msun/src/e_remainder.c b/lib/msun/src/e_remainder.c index a5fb7141d01a..cc6cd320073e 100644 --- a/lib/msun/src/e_remainder.c +++ b/lib/msun/src/e_remainder.c @@ -64,8 +64,8 @@ remainder(double x, double p) if(x>=p_half) x -= p; } } - GET_HIGH_WORD(hx,x); - if ((hx&0x7fffffff)==0) hx = 0; + EXTRACT_WORDS(hx, lx, x); + if (((hx&0x7fffffff)|lx) == 0) hx = 0; SET_HIGH_WORD(x,hx^sx); return x; }