From owner-cvs-all  Mon Jun  4 12:47:39 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6E02D37B401; Mon,  4 Jun 2001 12:47:33 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id FAA11274;
	Tue, 5 Jun 2001 05:47:30 +1000
Date: Tue, 5 Jun 2001 05:45:52 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: John Baldwin <jhb@FreeBSD.org>
Cc: Dima Dorfman <dd@FreeBSD.org>, cvs-all@FreeBSD.org,
	cvs-committers@FreeBSD.org
Subject: RE: cvs commit: src/sys/kern link_elf.c
In-Reply-To: <XFMail.010604110955.jhb@FreeBSD.org>
Message-ID: <Pine.BSF.4.21.0106050537370.59359-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 4 Jun 2001, John Baldwin wrote:

> On 03-Jun-01 Dima Dorfman wrote:
> > dd          2001/06/02 19:19:08 PDT
> > 
> >   Modified files:
> >     sys/kern             link_elf.c 
> >   Log:
> >   Include sys/mutex.h to silence a warning.
> 
> What warning?  It may be that the correct fix is to remove the bogus include of
> an unused header instead.

It's one of 4 similar warnings caused by alfred's vm changes.  From
yesterday's LINT error output:

In file included from ../../ddb/db_watch.c:41:
../../vm/vm_map.h: In function `_vm_map_lock_upgrade':
../../vm/vm_map.h:265: warning: implicit declaration of function `mtx_lock'
...
In file included from ../../kern/link_elf.c:52:
../../vm/vm_map.h: In function `_vm_map_lock_upgrade':
../../vm/vm_map.h:265: warning: implicit declaration of function `mtx_lock'
...
In file included from ../../i386/i386/math_emulate.c:50:
../../vm/vm_map.h: In function `_vm_map_lock_upgrade':
../../vm/vm_map.h:265: warning: implicit declaration of function `mtx_lock'
...
In file included from ../../i386/ibcs2/imgact_coff.c:46:
../../vm/vm_map.h: In function `_vm_map_lock_upgrade':
../../vm/vm_map.h:265: warning: implicit declaration of function `mtx_lock'

vm_map.h has a strange mixture of macros and inlines.  One of the
inlines calls mtx_lock().  Thus, everything that includes <vm/vm_map.h>
needs to know the implementation details of mutexes :-(.  The offending
function doesn't even seem to be part of the public interface of
vm_map.h.  It is only used in vm_map.c.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message