Date: Tue, 10 Jul 2012 00:04:48 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: sbruno@FreeBSD.org Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@FreeBSD.org>, Sean Bruno <seanbru@yahoo-inc.com>, rmacklem@FreeBSD.org Subject: Re: dtraceall.ko with old nfsclient Message-ID: <4FFB4770.7050209@FreeBSD.org> In-Reply-To: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com> References: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 09/07/2012 22:49 Sean Bruno said the following: > Ran into some symbol errors with the dtraceall module when using the > *old* nfs client. > > I think that this is more or less the right thing to do, but I'm not > sure. > > --- //depot/yahoo/ybsd_9/src/sys/modules/dtrace/dtraceall/dtraceall.c > 2011-11-02 23:46:55.000000000 0000 > +++ /home/seanbru/dtrace_9/src/sys/modules/dtrace/dtraceall/dtraceall.c > 2011-11-02 23:46:55.000000000 0000 > @@ -66,8 +66,11 @@ > MODULE_DEPEND(dtraceall, opensolaris, 1, 1, 1); > MODULE_DEPEND(dtraceall, dtrace, 1, 1, 1); > MODULE_DEPEND(dtraceall, dtmalloc, 1, 1, 1); > +#if defined (NFSCL) > MODULE_DEPEND(dtraceall, dtnfscl, 1, 1, 1); > +#else /* defined (NFSCLIENT) */ > MODULE_DEPEND(dtraceall, dtnfsclient, 1, 1, 1); > +#endif > #if defined(__amd64__) || defined(__i386__) > MODULE_DEPEND(dtraceall, fbt, 1, 1, 1); > MODULE_DEPEND(dtraceall, fasttrap, 1, 1, 1); Just to add some noise to the signal - my personal opinion is that nfs support doesn't have to be in dtraceall. Maybe in something "all-er" :-) -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FFB4770.7050209>