From owner-freebsd-hackers@FreeBSD.ORG  Mon Jul  9 21:04:55 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A7CEA106567F;
	Mon,  9 Jul 2012 21:04:55 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 8E9598FC12;
	Mon,  9 Jul 2012 21:04:54 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA08077;
	Tue, 10 Jul 2012 00:04:52 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1SoL8V-000L3Z-S0; Tue, 10 Jul 2012 00:04:51 +0300
Message-ID: <4FFB4770.7050209@FreeBSD.org>
Date: Tue, 10 Jul 2012 00:04:48 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:13.0) Gecko/20120620 Thunderbird/13.0.1
MIME-Version: 1.0
To: sbruno@FreeBSD.org
References: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com>
In-Reply-To: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@FreeBSD.org>,
	Sean Bruno <seanbru@yahoo-inc.com>, rmacklem@FreeBSD.org
Subject: Re: dtraceall.ko with old nfsclient
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jul 2012 21:04:55 -0000

on 09/07/2012 22:49 Sean Bruno said the following:
> Ran into some symbol errors with the dtraceall module when using the
> *old* nfs client.
> 
> I think that this is more or less the right thing to do, but I'm not
> sure.
> 
> --- //depot/yahoo/ybsd_9/src/sys/modules/dtrace/dtraceall/dtraceall.c
> 2011-11-02 23:46:55.000000000 0000
> +++ /home/seanbru/dtrace_9/src/sys/modules/dtrace/dtraceall/dtraceall.c
> 2011-11-02 23:46:55.000000000 0000
> @@ -66,8 +66,11 @@
>  MODULE_DEPEND(dtraceall, opensolaris, 1, 1, 1);
>  MODULE_DEPEND(dtraceall, dtrace, 1, 1, 1);
>  MODULE_DEPEND(dtraceall, dtmalloc, 1, 1, 1);
> +#if defined (NFSCL)
>  MODULE_DEPEND(dtraceall, dtnfscl, 1, 1, 1);
> +#else /* defined (NFSCLIENT) */
>  MODULE_DEPEND(dtraceall, dtnfsclient, 1, 1, 1);
> +#endif
>  #if defined(__amd64__) || defined(__i386__)
>  MODULE_DEPEND(dtraceall, fbt, 1, 1, 1);
>  MODULE_DEPEND(dtraceall, fasttrap, 1, 1, 1);

Just to add some noise to the signal - my personal opinion is that nfs support
doesn't have to be in dtraceall.  Maybe in something "all-er" :-)


-- 
Andriy Gapon