From owner-svn-src-all@freebsd.org Thu Feb 22 16:34:09 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89453F14973 for ; Thu, 22 Feb 2018 16:34:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 139486C3D8 for ; Thu, 22 Feb 2018 16:34:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id u5so1148422itc.1 for ; Thu, 22 Feb 2018 08:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=DeS/74QsBXxEoVSsUqAMRv7LRpSAI2XT8+bDNQP/Qsk=; b=bfeTKAUwiNb/wmAISH/0yGwFJzQlbpjcKsVzxJhJowGFiu87OXH4J5NNJitkJ9oNfe o7YO36yQl7SR/djbles5qflFD0OLnEip64hcxG7a7jtDN3YgoMSscJN8fEg3fV4iXSIZ rA0UkzckINZqeryydoS0On1WfGI/MGPhxQKysib8XKNa2jqxxqGrrFYYA1zp1LqpblQC iqFGeiUi+BWNgKxPXi39xdTwRXcsayc+ZLd1oCOWLNL6iB3L10mX6NSewTpogH+6SRO7 848kndXaH17vq2bMQ/LyDZfUZB/GJKTao6OP3wHBdDScIvks4uWyu3H8U/EcX7RicPXc dheQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=DeS/74QsBXxEoVSsUqAMRv7LRpSAI2XT8+bDNQP/Qsk=; b=AVd/rUU/dA9uzXiTEi6Norfd6rVNVOkkoLdWdQxXG2amvNJoWqz2nBowy+rkubfdh8 +xN3d0pfqOEGIoH9j404A/oj3nxab4hh+nFHTXpRo7ZbeF6ofKw6UirktjPo38TwLgLq a5Z3F/2oQt115oUKIvzLQN8OgzLaxm80i7pRZ3Xk8VM2KXpE+850LcVsvDI8buYUHvmX CeWwxR9eVUSvAZlm1z7+1Zfc/vOOx9CMMl5UNARXRH05gkxJSCCM9B/UCWHwGWEIeV2C vr3KdYCDLajbQpYl75YSlRhcAGPySHZEBmAe70CFKW0gRuWiQX34sZ0ac7AL24mA1iVN Kh+Q== X-Gm-Message-State: APf1xPBkeUHsfA5chy3OPbtgKDwFCoustzXP33pYgMWuggM9ECwe+XWe 6RsHuXwHPKMVCA299YU4mdBM/IX14L7Zvd59hZ1LTQ== X-Google-Smtp-Source: AH8x225GMKyQBFtQ7mmTmn8HAGJj8mFIXqwdr5pLyxxIEPeHF7AFkQmzzY72E85mdUmjC3tKCESid5HIhBhwaz+lAkc= X-Received: by 10.36.111.4 with SMTP id x4mr9030884itb.51.1519317248194; Thu, 22 Feb 2018 08:34:08 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Thu, 22 Feb 2018 08:34:07 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: References: <201802221332.w1MDWVao004564@repo.freebsd.org> From: Warner Losh Date: Thu, 22 Feb 2018 09:34:07 -0700 X-Google-Sender-Auth: X0ynUdQ1fGoV8w9HBmMLouyFk74 Message-ID: Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme To: Wojciech Macek Cc: Alan Somers , Kyle Evans , Wojciech Macek , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 16:34:09 -0000 I know all about losing things during the rebase.... I'd be a lot happier if you could confirm that nothing else was lost. It's a large patch, which makes it impossible for others to do it... It seems to build, and seems to be working in the light testing I've done this morning... Warner On Thu, Feb 22, 2018 at 9:31 AM, Wojciech Macek wrote: > Thanks and sorry for troubles! > These lines must have got lost somewhere during rebase as we run tinderbox > with this patch yesterday. > > Regards, > Wojtek > wma@ > > 2018-02-22 17:22 GMT+01:00 Alan Somers : > >> On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: >> >>> On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers >>> wrote: >>> > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek >>> wrote: >>> > >>> >> Author: wma >>> >> Date: Thu Feb 22 13:32:31 2018 >>> >> New Revision: 329824 >>> >> URL: https://svnweb.freebsd.org/changeset/base/329824 >>> >> >>> >> Log: >>> >> NVMe: Add big-endian support >>> >> >>> >> Remove bitfields from defined structures as they are not portable. >>> >> Instead use shift and mask macros in the driver and nvmecontrol >>> >> application. >>> >> >>> >> NVMe is now working on powerpc64 host. >>> >> >>> >> Submitted by: Michal Stanek >>> >> Obtained from: Semihalf >>> >> Reviewed by: imp, wma >>> >> Sponsored by: IBM, QCM Technologies >>> >> Differential revision: https://reviews.freebsd.org/D13916 >>> >> >>> > >>> > It looks like this change broke the build with Clang: >>> > >>> >>> Fixed in r329827... all little endian arch's broken, not so great. =( >>> >> >> Fast work, Kyle. Thanks a bundle. >> -Alan >> > >