From owner-freebsd-arm@FreeBSD.ORG Fri Feb 20 15:23:01 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9EDC2EC8 for ; Fri, 20 Feb 2015 15:23:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7D8A6AB8 for ; Fri, 20 Feb 2015 15:23:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1KFN1va049346 for ; Fri, 20 Feb 2015 15:23:01 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1KFN16D049345; Fri, 20 Feb 2015 15:23:01 GMT (envelope-from root) Date: Fri, 20 Feb 2015 15:23:01 +0000 To: freebsd-arm@freebsd.org From: "nwhitehorn (Nathan Whitehorn)" Subject: [Differential] [Changed Subscribers] D1912: Fix endianness on FDT read in ARM GIC Message-ID: X-Priority: 3 Thread-Topic: D1912: Fix endianness on FDT read in ARM GIC X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YmE3NzVmMjk2ZDk4MjdlMDE0NzYyNDAwMDVmIFTnUVU= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 15:23:01 -0000 nwhitehorn added a subscriber: nwhitehorn. nwhitehorn added a comment. This is a good patch. The spec defines that interrupts properties are in 32-bit chunks "encoded as with " (i.e. big-endian and 32-bits at a time), so all endian decoding should be confined to OF_getencprop() calls in ofw_bus_intr_to_rl(). REVISION DETAIL https://reviews.freebsd.org/D1912 To: zbb, imp, andrew Cc: nwhitehorn, onwahe-gmail-com, freebsd-arm