From owner-freebsd-hackers@freebsd.org Mon Dec 7 04:51:10 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 511F3476F5B for ; Mon, 7 Dec 2020 04:51:10 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Cq9qy1nB4z3rN9 for ; Mon, 7 Dec 2020 04:51:10 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3B2CE477303; Mon, 7 Dec 2020 04:51:10 +0000 (UTC) Delivered-To: hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3AF4947713E for ; Mon, 7 Dec 2020 04:51:10 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cq9qy19npz3r6n; Mon, 7 Dec 2020 04:51:10 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from localhost (unknown [IPv6:2400:4051:a743:3c00:16:ceff:fe34:2700]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: hrs) by smtp.freebsd.org (Postfix) with ESMTPSA id 1D6C31CE; Mon, 7 Dec 2020 04:51:08 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Date: Mon, 07 Dec 2020 13:50:56 +0900 (JST) Message-Id: <20201207.135056.445534109566789594.hrs@FreeBSD.org> To: yuripv@yuripv.dev Cc: thomas.munro@gmail.com, bapt@freebsd.org, hackers@freebsd.org Subject: Re: locale-related review, wcwidth() data From: Hiroki Sato In-Reply-To: <14fbfd11-a5fa-4e7e-422c-33738364c58d@yuripv.dev> References: <20201204133111.uyu55cl7zgll4vk2@ivaldir.net> <14fbfd11-a5fa-4e7e-422c-33738364c58d@yuripv.dev> X-Old-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-PGPkey-fingerprint: 6C0D 2353 27CF 80C7 901E FDD2 DBB0 7DC6 6F1F 737F X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="--Security_Multipart(Mon_Dec__7_13_50_56_2020_585)--" Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 04:51:10 -0000 ----Security_Multipart(Mon_Dec__7_13_50_56_2020_585)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Yuri Pankov wrote in <14fbfd11-a5fa-4e7e-422c-33738364c58d@yuripv.dev>: yu> Thomas Munro wrote: yu> > On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin yu> > wrote: yu> >> I do like what I see here, the only reason I haven't review is that I yu> >> can't yu> >> test, since the last modification from hrs@ in the locale generation yu> >> tools each yu> >> time I try to regenerate the locales it fails. yu> > During install? I noticed that too but wasn't sure of the correct yu> > fix, perhaps: yu> > diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile yu> > index 76fff6acb17..b6ae2feadac 100644 yu> > --- a/tools/tools/locale/Makefile yu> > +++ b/tools/tools/locale/Makefile yu> > @@ -95,7 +95,7 @@ install: install-${t} yu> > install-${t}: yu> > cd ${LOCALESRCDIR}/${t} && \ yu> > rm -f Makefile *.src && \ yu> > - install -c ${t}/* ${LOCALESRCDIR}/${t} yu> > + install -c ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t} yu> > . endif yu> > .endfor yu> yu> Makes sense. yu> yu> BTW, to test what is in this review, you don't need the install target yu> -- new 'width' target depends only on cldr posix data itself, and yu> modifies etc/final-maps/widths.txt directly. Sorry for keeping silence about the report. I fixed it in r368404. -- Hiroki ----Security_Multipart(Mon_Dec__7_13_50_56_2020_585)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iMoEABMKAC4WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCX820sBAcaHJzQGZyZWVi c2Qub3JnAAoJENuwfcZvH3N/qWUCCQG4Y34bepjAvUbW/h7swRh7efUT/82q8BmC aFjJjUUQdJUJRp0z2m0zN8Jy6J3sOkyLuIEVqcnVTG6WHi98+PD7QAIJAWT2Og52 7dDoL0MaFOQHxtnMpc9vdRIUw92MherZBwQiddtP/kRCxz/h+P++fbJd6LzMeMLE 16krBNNb5Xrroa6A =ulMB -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Dec__7_13_50_56_2020_585)----