From owner-svn-src-all@freebsd.org Thu Jan 14 09:47:54 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC0A6A8018E; Thu, 14 Jan 2016 09:47:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-ob0-x236.google.com (mail-ob0-x236.google.com [IPv6:2607:f8b0:4003:c01::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B095A13C5; Thu, 14 Jan 2016 09:47:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-ob0-x236.google.com with SMTP id ba1so488710379obb.3; Thu, 14 Jan 2016 01:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=lhlFJ89z+I4BuIBNLmiEgmZZe73RzVAL6sUc+7BKzso=; b=yPLvBvcHa042QRkvK/mJ5DVw+aYeUI9nlabiTzLWEjMh0xArAFqP60zk4FXJuBc2c8 8pjRouY6ez7h2B9Lpg6+cr0/27zgDeF6Or0nPi4gw2u49DOVX6AXMXaSQd43Mueq3SBA nlJkwhwAVt638qKHjfnFVSfv53ZL0Be1dS2jWtWLk+qWRYL8Up7iPcVJfPY5iGQCp1AC Hza8p/rxjn3MS5KlucfuOSoFNlL8qNktd2Ls3ooxcq/6TRr5mbH1PQXiWFm3bsOi5Ubv vDzykglwp1yAks22exUbGpgozmmopANwmIIjLNXKuM2lx8aR4cl2hC5Q9kFzTfW8Mw/q gRJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=lhlFJ89z+I4BuIBNLmiEgmZZe73RzVAL6sUc+7BKzso=; b=EzbOZGX3osk3bwkeAITW5e5dYB9BgpuHWLc84j8hJFsQY8qmyAjjHcCN+aRM5D/p8i 62jBt9uuIGVYkV5v75Pjx6GJtdHUNyV4ydtki/uPHqmClbP+4VOQ8Q6roFJVf1LC9osG atH38WSXWWginocxTQf/quzv2STZu6oYi5aFQ9AIjADY4r/RBl3JF5/Pp8VEDgCZG8gE SE0HR72tsWOXfrLuIPeotDOUHj6F7XGH1PDqZknob6/dAzxQ+3lbQD2rjvGo1KUJUok5 1evE93+QPTxNb8hNmTRpXsH+LV0YsOfcIGTU2gp+QAkWDzMykNJlCMthA2U00Zj1ttbZ aDRQ== X-Gm-Message-State: ALoCoQkxlP6kMg3PYUrDlEp+1g48rYwdNvYQ5GpLureRLwc4SD04bJSF8rF5yD55GuQumy+g9fwbMtrdDuyll/ryonNCO281Xg== X-Received: by 10.182.242.4 with SMTP id wm4mr2249086obc.85.1452764873993; Thu, 14 Jan 2016 01:47:53 -0800 (PST) Received: from ?IPv6:2601:601:800:126d:f478:ccdc:ca0f:26df? ([2601:601:800:126d:f478:ccdc:ca0f:26df]) by smtp.gmail.com with ESMTPSA id w143sm3113332oiw.16.2016.01.14.01.47.52 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 01:47:52 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi From: NGie Cooper In-Reply-To: Date: Thu, 14 Jan 2016 01:47:50 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <9A7534C4-0A2C-4DAC-981A-09868F1723DA@gmail.com> References: <201601140922.u0E9M1rV025146@repo.freebsd.org> To: Steven Hartland X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 09:47:55 -0000 > On Jan 14, 2016, at 01:27, NGie Cooper wrote: >=20 >=20 >> On Jan 14, 2016, at 01:22, Steven Hartland wrote: >>=20 >> Author: smh >> Date: Thu Jan 14 09:22:01 2016 >> New Revision: 293903 >> URL: https://svnweb.freebsd.org/changeset/base/293903 >>=20 >> Log: >> Fix GCC warnings causing build failure after r293724 >>=20 >> Disable some compiler warnings for GCC (non-standard compiler) fixing >> build failures introduced by r293724, which enabled WARNS in the EFI = boot >> code, when compiling with none standard compiler (GCC). >=20 > Disabling warnings is wrong. Here=E2=80=99s how arm could be fixed: >=20 > $ svn diff sys/boot/ > Index: sys/boot/common/bootstrap.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/boot/common/bootstrap.h (revision 293877) > +++ sys/boot/common/bootstrap.h (working copy) > @@ -32,6 +32,7 @@ > #include > #include > #include > +#include >=20 > /* > * Generic device specifier; architecture-dependant=20 > @@ -332,12 +333,8 @@ > extern struct arch_switch archsw; >=20 > /* This must be provided by the MD code, but should it be in the = archsw? */ > -void delay(int delay); > - > void dev_cleanup(void); >=20 > -time_t time(time_t *tloc); > - > #ifndef CTASSERT /* Allow lint to override */ > #define CTASSERT(x) _CTASSERT(x, __LINE__) > #define _CTASSERT(x, y) __CTASSERT(x, y) > Index: sys/boot/efi/include/efiapi.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/boot/efi/include/efiapi.h (revision 293877) > +++ sys/boot/efi/include/efiapi.h (working copy) > @@ -532,6 +532,7 @@ > typedef > EFI_STATUS > (EFIAPI *EFI_RESERVED_SERVICE) ( > + VOID > ); >=20 > typedef >=20 > amd64 is a bit trickier: >=20 > /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/efigop.h:75: = warning: 'ms_abi' attribute directive ignored >=20 > I didn=E2=80=99t dig into why this is happening [yet], other than = there maybe being MS extensions involved? >=20 > Thanks, > -NGie This might fix amd64: Index: = /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind.h = (revision 293877) +++ /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind.h = (working copy) @@ -160,8 +160,10 @@ // =20 #ifdef __amd64__ +#if defined(__clang__) && (__clang_major__ >=3D 3 && __clang_minor__ >=3D= 5) #define EFIAPI __attribute__((ms_abi)) #endif +#endif =20 #ifndef EFIAPI // Forces EFI calling conventions = reguardless of compiler options=20 #ifdef _MSC_EXTENSIONS