From owner-cvs-all@FreeBSD.ORG Sat Nov 4 20:30:36 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4084B16A412; Sat, 4 Nov 2006 20:30:36 +0000 (UTC) (envelope-from jb@what-creek.com) Received: from what-creek.com (what-creek.com [66.111.37.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3048443D7C; Sat, 4 Nov 2006 20:30:26 +0000 (GMT) (envelope-from jb@what-creek.com) Received: by what-creek.com (Postfix, from userid 102) id 5277C140EC03; Sat, 4 Nov 2006 20:31:51 +0000 (GMT) Date: Sat, 4 Nov 2006 20:31:51 +0000 From: John Birrell To: "Simon L. Nielsen" Message-ID: <20061104203150.GB2027@what-creek.com> References: <200611040458.kA44wAKN097086@repoman.freebsd.org> <20061104091155.GA12770@zaphod.nitro.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061104091155.GA12770@zaphod.nitro.dk> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, John Birrell , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/conf DEFAULTS src/sys/i386/conf DEFAULTS src/sys/ia64/conf DEFAULTS src/sys/pc98/conf DEFAULTS src/sys/powerpc/conf DEFAULTS src/sys/sparc64/conf DEFAULTS src/sys/sparc64/sparc64 machdep.c src/sys/sun4v/conf DEFAULTS X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2006 20:30:36 -0000 On Sat, Nov 04, 2006 at 10:11:56AM +0100, Simon L. Nielsen wrote: > Why isn't it just in GENERIC so people can easily disable it if they > like? I thought DEFAULTS was just meant for things which caused users > pain (and people answering support mails...) if they accidentally > missed the option? I don't really see DTrace falling in that > category. I added it to DEFAULTS so that it would be available automatically for people who didn't know that they want it. 8-) Adding it to GENERIC doesn't cover the people who have their own kernel configs. And they can still disable it in GENERIC or whatever config they are using just as easily as they could add it. The point is that there is negligible run-time impact and only a small increase in code size to have it enabled. Remember it's only the hooks and a few support functions. The guts of DTrace is in the 'dtrace' kernel module (and the associated providers) which still have to be loaded as modules. -- John Birrell