From owner-freebsd-current Mon Jan 27 8:49:54 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0938D37B406 for ; Mon, 27 Jan 2003 08:49:53 -0800 (PST) Received: from mail03.svc.cra.dublin.eircom.net (mail03.svc.cra.dublin.eircom.net [159.134.118.19]) by mx1.FreeBSD.org (Postfix) with SMTP id 4B78643ED8 for ; Mon, 27 Jan 2003 08:49:51 -0800 (PST) (envelope-from pmedwards@eircom.net) Received: (qmail 72237 messnum 3732904 invoked from network[159.134.237.83/otto.eircom.net]); 27 Jan 2003 16:49:45 -0000 Received: from otto.eircom.net (HELO webmail.eircom.net) (159.134.237.83) by mail03.svc.cra.dublin.eircom.net (qp 72237) with SMTP; 27 Jan 2003 16:49:45 -0000 From: "Peter Edwards" To: phk@freebsd.org Cc: freebsd-current@freebsd.org Subject: Re: Opening /dev/tty in session leader after controlling terminal is revoked causes panic. Date: Mon, 27 Jan 2003 16:49:45 +0000 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Originating-IP: 62.17.151.61 X-Mailer: Eircom Net CRC Webmail (http://www.eircom.net/) Organization: Eircom Net (http://www.eircom.net/) Message-Id: <20030127164951.4B78643ED8@mx1.FreeBSD.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG phk@freebsd.org wrote: > > In message <20030125183411.997FE43F43@mx1.FreeBSD.org>, "Peter Edwards" writes: > > >The problem is in kern/tty_tty.c:ctty_clone. It's assuming that if the process > >has its P_CONTROLT flag set, then it's session has a valid vnode for it's > >controlling terminal. This doesn't hold if the terminal was revoked. > > Can you try this patch ? [snip patch] Yes, this patch also fixes the problem. -- Peter Edwards. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message