From owner-freebsd-fs Mon Sep 23 07:28:38 1996 Return-Path: owner-fs Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id HAA17295 for fs-outgoing; Mon, 23 Sep 1996 07:28:38 -0700 (PDT) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id HAA17260; Mon, 23 Sep 1996 07:28:34 -0700 (PDT) Received: (from root@localhost) by dyson.iquest.net (8.7.5/8.6.9) id JAA11836; Mon, 23 Sep 1996 09:24:46 -0500 (EST) From: "John S. Dyson" Message-Id: <199609231424.JAA11836@dyson.iquest.net> Subject: Re: vnode_pager_uncache() To: dfr@render.com (Doug Rabson) Date: Mon, 23 Sep 1996 09:24:46 -0500 (EST) Cc: fs@freebsd.org, lite2@freebsd.org In-Reply-To: from "Doug Rabson" at Sep 23, 96 02:51:49 pm Reply-To: dyson@freebsd.org X-Mailer: ELM [version 2.4 PL24 ME8] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-fs@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > I want to add a struct proc* argument to this call. The reason is that > lite2 has a struct proc* argument to vn_lock/VOP_UNLOCK and panics if the > wrong process unlocks a vnode. This causes trouble for the odd cases like > shutdown where a process other than curproc is given to the filesystem > since vnode_pager_uncache needs to manipulate the vnode lock sometimes. > > I can hack around it by ignoring the passed proc and substituting curproc > in the places which matter but the right thing to do is for > vnode_pager_uncache to use the correct proc. > Sounds okay. Continue in that direction, and later on after work, I'll review it more carefully. (in a hurry to go to work :-)). John