From owner-svn-src-head@FreeBSD.ORG Mon Jul 13 23:23:10 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30466106566B; Mon, 13 Jul 2009 23:23:10 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id D52A38FC12; Mon, 13 Jul 2009 23:23:09 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.local (pooker.samsco.org [168.103.85.57]) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id n6DNN4Mo044740; Mon, 13 Jul 2009 17:23:05 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4A5BC1D7.8080300@samsco.org> Date: Mon, 13 Jul 2009 17:23:03 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Marcel Moolenaar References: <200907130612.n6D6CLMP014560@svn.freebsd.org> <4C53B490-A1B0-4841-81B2-A8F06D353349@mac.com> In-Reply-To: <4C53B490-A1B0-4841-81B2-A8F06D353349@mac.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, Alexander Motin , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r195653 - head/sys/cam/ata X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2009 23:23:10 -0000 Marcel Moolenaar wrote: > > On Jul 12, 2009, at 11:12 PM, Alexander Motin wrote: > >> Author: mav >> Date: Mon Jul 13 06:12:21 2009 >> New Revision: 195653 >> URL: http://svn.freebsd.org/changeset/base/195653 >> >> Log: >> Rename ATA probe driver to "aprobe" to resolve name conflict with SCSI >> and fix loading cam as module. > > While this may avoid a conflict, it's hardly a good name that > has a low chance of conflicting with something else. > > Please consider (in due time) to improve the descriptiveness. > Something like "ata_cam_probe" doesn't look like a bad choice > to me... > > Just food for thought... > Is there nothing else in this entire piece of work that can be commented on besides the goddamned names? Holy hell. The bikeshed, it's not just a cliche, it's a f@@@ing way of life around here. Scott