From owner-freebsd-current@FreeBSD.ORG Thu Aug 26 15:31:39 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6CE516A4CE for ; Thu, 26 Aug 2004 15:31:39 +0000 (GMT) Received: from mail.freebsd.org.cn (dns3.freebsd.org.cn [61.129.66.75]) by mx1.FreeBSD.org (Postfix) with SMTP id AB74E43D49 for ; Thu, 26 Aug 2004 15:31:37 +0000 (GMT) (envelope-from junsu@delphij.net) Received: (qmail 39514 invoked by uid 0); 26 Aug 2004 15:28:33 -0000 Received: from unknown (HELO beastie.frontfree.net) (219.239.98.7) by mail.freebsd.org.cn with SMTP; 26 Aug 2004 15:28:33 -0000 Received: from localhost (localhost.frontfree.net [127.0.0.1]) by beastie.frontfree.net (Postfix) with ESMTP id A2E08131943; Thu, 26 Aug 2004 23:31:33 +0800 (CST) Received: from beastie.frontfree.net ([127.0.0.1]) by localhost (beastie.frontfree.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 00122-09; Thu, 26 Aug 2004 23:31:26 +0800 (CST) Received: from [211.161.222.225] (unknown [211.161.222.225]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by beastie.frontfree.net (Postfix) with ESMTP id 943A8131860; Thu, 26 Aug 2004 23:31:22 +0800 (CST) Message-ID: <412E0243.1050808@delphij.net> Date: Thu, 26 Aug 2004 23:31:15 +0800 From: Jun Su User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040816 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Maxim Sobolev References: <412DF886.4030107@portaone.com> In-Reply-To: <412DF886.4030107@portaone.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at frontfree.net X-Mailman-Approved-At: Fri, 27 Aug 2004 11:58:54 +0000 cc: current@FreeBSD.org Subject: Re: [patch] bug in cpp's #ident handling in gcc 3.4 [Was: ccache with buildworld] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2004 15:31:40 -0000 Maxim Sobolev wrote: > Hi there, > > I was looking into the problem with building world using ccache. It was > failing with the following error message: > > /usr/src/lib/libc/rpc/key_call.c:33:10: extra tokens at end of #ident > directive > > > It would be nice to get it committed before 5.3 is out. > > Regards, > > Maxim > > > ------------------------------------------------------------------------ > > --- src/contrib/gcc/c-ppoutput.c 2004/08/26 14:10:04 1.1 > +++ src/contrib/gcc/c-ppoutput.c 2004/08/26 14:10:32 > @@ -292,7 +292,7 @@ > const cpp_string *str) > { > maybe_print_line (print.map, line); > - fprintf (print.outf, "#ident \"%s\"\n", str->text); > + fprintf (print.outf, "#ident %s\n", str->text); > print.line++; > } > In the files of the same folder, '#ident' are all in the /* */. I think fix key_call.c to put #ident into comments makes more sense than change gcc behaivr. Jun Su %grep -r '#ident' /usr/src/lib/libc/* /usr/src/lib/libc/rpc/clnt_bcast.c:/* #ident "@(#)clnt_bcast.c 1.18 94/05/03 SMI" */ /usr/src/lib/libc/rpc/clnt_dg.c:/* #ident "@(#)clnt_dg.c 1.23 94/04/22 SMI" */ /usr/src/lib/libc/rpc/clnt_generic.c:/* #ident "@(#)clnt_generic.c 1.40 99/04/21 SMI" */ /usr/src/lib/libc/rpc/key_call.c:#ident "@(#)key_call.c 1.25 94/04/24 SMI" /usr/src/lib/libc/rpc/rpc_soc.c:/* #ident "@(#)rpc_soc.c 1.17 94/04/24 SMI" */ /usr/src/lib/libc/rpc/rpcb_clnt.c:/* #ident "@(#)rpcb_clnt.c 1.27 94/04/24 SMI" */ /usr/src/lib/libc/rpc/rpcb_prot.c:/* #ident "@(#)rpcb_prot.c 1.13 94/04/24 SMI" */ /usr/src/lib/libc/rpc/svc_auth.c:/* #ident "@(#)svc_auth.c 1.16 94/04/24 SMI" */ /usr/src/lib/libc/rpc/svc_dg.c:/* #ident "@(#)svc_dg.c 1.17 94/04/24 SMI" */ /usr/src/lib/libc/rpc/svc_generic.c:/* #ident "@(#)svc_generic.c 1.19 94/04/24 SMI" */ /usr/src/lib/libc/rpc/svc_raw.c:/* #ident "@(#)svc_raw.c 1.16 94/04/24 SMI" */