From owner-dev-commits-src-all@freebsd.org Sun Jan 31 18:41:19 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1FFCC522855; Sun, 31 Jan 2021 18:41:19 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DTKfR0VX5z4SHn; Sun, 31 Jan 2021 18:41:19 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from ubik.madpilot.net (host-79-12-130-69.retail.telecomitalia.it [79.12.130.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 73661497F; Sun, 31 Jan 2021 18:41:18 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: git: aa906e2a4957 - main - OpenSSL: Support for kernel TLS offload (KTLS) To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202101281825.10SIPTGJ021104@gitrepo.freebsd.org> From: Guido Falsi Message-ID: <8257bc17-3a2d-f348-a0d5-fbd0f637629f@FreeBSD.org> Date: Sun, 31 Jan 2021 19:41:16 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <202101281825.10SIPTGJ021104@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jan 2021 18:41:19 -0000 On 28/01/21 19:25, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=aa906e2a4957db700d9e6cc60857e1afe1aecc85 > > commit aa906e2a4957db700d9e6cc60857e1afe1aecc85 > Author: John Baldwin > AuthorDate: 2021-01-16 00:17:31 +0000 > Commit: John Baldwin > CommitDate: 2021-01-28 18:24:13 +0000 > > OpenSSL: Support for kernel TLS offload (KTLS) > > This merges upstream patches from OpenSSL's master branch to add > KTLS infrastructure for TLS 1.0-1.3 including both RX and TX > offload and SSL_sendfile support on both Linux and FreeBSD. > > Note that TLS 1.3 only supports TX offload. > > A new WITH/WITHOUT_OPENSSL_KTLS determines if OpenSSL is built with > KTLS support. It defaults to enabled on amd64 and disabled on all > other architectures. > > Reviewed by: jkim (earlier version) > Approved by: secteam > Obtained from: OpenSSL (patches from master) > MFC after: 1 week > Relnotes: yes > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D28273 > --- This commit causes a strange interaction/regression with subverison client when using https protocol. I filed a bug report about this: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253135 Workarounds: - Compiling system defining WITHOUT_OPENSSL_KTLS - using the svn:// scheme -- Guido Falsi