Date: Sat, 14 Aug 2004 12:27:14 -0500 (CDT) From: "Conrad J. Sabatier" <conrads@cox.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: deischen@FreeBSD.org Subject: ports/70457: ports/editors/nedit fix for broken build Message-ID: <200408141727.i7EHRE2A090604@dolphin.local.net> Resent-Message-ID: <200408141730.i7EHUITR032425@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 70457
>Category: ports
>Synopsis: ports/editors/nedit fix for broken build
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Aug 14 17:30:18 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Conrad J. Sabatier
>Release: FreeBSD 5.2-CURRENT amd64
>Organization:
None
>Environment:
System: FreeBSD dolphin.local.net 5.2-CURRENT FreeBSD 5.2-CURRENT #2: Fri Aug 13 21:23:53 CDT 2004 conrads@dolphin.local.net:/usr/obj/usr/src/sys/CUSTOM amd64
>Description:
The nedit port, in its current state, will not build on most
people's machines. This is due to the fact that the make variable
"-DBUILD_BROKEN_NEDIT" (needed to override the version-specific Motif
requirement) is being defined in the port's ${.CURDIR}/Makefile, rather
than in the file ${WRKSRC}/makefiles/makefile.freebsd, as suggested by the
port's author(s).
In previous discussions with the port's maintainer, he asserted
that the line "CFLAGS+=-DBUILD_BROKEN_NEDIT" in ${.CURDIR}/Makefile was
sufficient *IF* the user's /etc/make.conf used "CFLAGS+=" rather than
"CFLAGS=". While this is true, nonetheless, the proper fix, and one that
would work regardless of the user's make.conf syntax, is the one suggested
by the port's author(s), i.e., to add "-DBUILD_BROKEN_NEDIT" to CFLAGS in
the port's machine-specific Makefile
(${WRKSRC}/makefiles/makefile.freebsd, in our case).
I am *imploring* the port's maintainer to please agree to this correction,
so as to correct this long-standing problem with an otherwise very fine
port.
>How-To-Repeat:
Try building the port, with a "CFLAGS=" line in /etc/make.conf.
The build will fail.
>Fix:
Apply the following patches to ports/nedit/Makefile and
ports/nedit/files/patch-ac:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/editors/nedit/Makefile,v
retrieving revision 1.34
diff -u -r1.34 Makefile
--- Makefile 7 Feb 2004 23:38:14 -0000 1.34
+++ Makefile 14 Aug 2004 16:58:08 -0000
@@ -25,7 +25,6 @@
MAN1= nclient.1 nedit.1
ALL_TARGET= freebsd
MAKE_ENV+= BINOWN=${BINOWN} BINGRP=${BINGRP} BINMODE=${BINMODE}
-CFLAGS+= -DBUILD_BROKEN_NEDIT
post-extract:
${CP} ${DISTDIR}/nedit.app-defaults ${WRKSRC}/NEdit.ad
Index: files/patch-ac
===================================================================
RCS file: /home/ncvs/ports/editors/nedit/files/patch-ac,v
retrieving revision 1.3
diff -u -r1.3 patch-ac
--- files/patch-ac 7 Feb 2004 23:38:14 -0000 1.3
+++ files/patch-ac 14 Aug 2004 17:01:17 -0000
@@ -15,7 +15,7 @@
#
-CFLAGS=-O -I${PREFIX}/include -DUSE_DIRENT -DUSE_LPR_PRINT_CMD -DUSE_XMIM
-LIBS= ${MOTIFLIB} -L${PREFIX}/lib -lm -lXpm -lXext -lXt -lSM -lICE -lX11
-+CFLAGS+=-O -I${X11BASE}/include -DUSE_DIRENT -DUSE_LPR_PRINT_CMD -DUSE_XMIM
++CFLAGS+=-O -I${X11BASE}/include -DUSE_DIRENT -DUSE_LPR_PRINT_CMD -DUSE_XMIM -DBUILD_BROKEN_NEDIT
+LIBS+= ${MOTIFLIB} -L${X11BASE}/lib -lm -lXpm -lXext -lXt -lSM -lICE -lX11
include Makefile.common
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408141727.i7EHRE2A090604>