From owner-freebsd-current Wed Apr 10 4: 0:47 2002 Delivered-To: freebsd-current@freebsd.org Received: from mailout05.sul.t-online.com (mailout05.sul.t-online.com [194.25.134.82]) by hub.freebsd.org (Postfix) with ESMTP id 301DD37B41B; Wed, 10 Apr 2002 04:00:40 -0700 (PDT) Received: from fwd09.sul.t-online.de by mailout05.sul.t-online.com with smtp id 16vEf0-0005Cs-0M; Wed, 10 Apr 2002 11:45:02 +0200 Received: from Magelan.Leidinger.net (520065502893-0001@[80.131.116.187]) by fmrl09.sul.t-online.com with esmtp id 16vEew-0xoPZ2C; Wed, 10 Apr 2002 11:44:58 +0200 Received: from Leidinger.net (netchild@localhost [127.0.0.1]) by Magelan.Leidinger.net (8.12.2/8.12.2) with ESMTP id g3A9j1HA000728; Wed, 10 Apr 2002 11:45:05 +0200 (CEST) (envelope-from netchild@Leidinger.net) Message-Id: <200204100945.g3A9j1HA000728@Magelan.Leidinger.net> Date: Wed, 10 Apr 2002 11:45:01 +0200 (CEST) From: Alexander Leidinger Subject: Re: libkern/quad.h To: obrien@FreeBSD.org Cc: current@FreeBSD.ORG In-Reply-To: <20020410021832.A57790@dragon.nuxi.com> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-Sender: 520065502893-0001@t-dialin.net Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 10 Apr, David O'Brien wrote: > On Tue, Apr 09, 2002 at 04:58:42PM +0200, Alexander Leidinger wrote: >> quad.h contains: >> ---snip--- >> /* >> * XXX >> * Compensate for gcc 1 vs gcc 2. Gcc 1 defines ?sh?di3's second argument >> * as u_quad_t, while gcc 2 correctly uses int. Unfortunately, we still use >> * both compilers. >> */ >> #if __GNUC__ >= 2 >> typedef unsigned int qshift_t; >> #else >> typedef u_quad_t qshift_t; >> #endif >> ---snip--- >> >> Is this still valid? Does someone really use gcc 1 to compile FreeBSD? > > I assume your question stems from trying to use icc. Please wrap this > bit [semi]-properly with: > > #ifdef __GNUC__ > #if __GNUC__ >= 2 > typedef unsigned int qshift_t; > #else > typedef u_quad_t qshift_t; > #endif > #endif > > You can then put a defintion for #ifdef __IC > Fullquote because your message seems to be truncated... Yes, your assumption is correct. And BDE already said this particular example became invalid before FreeBSD-2.0. I think it is ok to remove this particular example entirely and just use the first typedef. As for other occourences of the use of __GNUC__ without a check if it is defined: I will wrap them as soon as I review my own patches again. Bye, Alexander. P.S.: Any news on the icc <-> linux_base issue? -- Intel: where Quality is job number 0.9998782345! http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message