From owner-freebsd-mips@FreeBSD.ORG Thu Jun 17 16:23:11 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 892741065673; Thu, 17 Jun 2010 16:23:11 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id 2E3FC8FC15; Thu, 17 Jun 2010 16:23:10 +0000 (UTC) Received: by yxm34 with SMTP id 34so2890671yxm.13 for ; Thu, 17 Jun 2010 09:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=gmmJl7bP1U1Tap1Q7BE+4hq5+M+Wpxf1ZvKj80a5kFs=; b=MxF7k54Sac4uUQS3ouyAYzN+q3YRv95/GA4YnuokRpudM2LI6sGHdfseexUDovNWe4 RmREHBLjN/4t5M0Oj63GQguOWU5yqNjxtn00IGiOw/msEiOi54IYRohYSMAaZEckr1eK 6cWSH3bOoiNcwYsTrabr5lcq6jdlwOUluCjs0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ZcCiAnj5wAExa243jcrpYDjmRxgoAQlQUvUP58+s/N/U45xEcslAL05i3BfY6MXVIU 180RNCkUvyakhV8SLxNByDuVg/9mkt5KG+yZy28a95M+TS7cF/yrdrKUUgNgw5+TxNwP ljaX2cTirc1lahJrYKS4GBkqc5xdb7GkDRAxk= MIME-Version: 1.0 Received: by 10.224.39.66 with SMTP id f2mr5159134qae.157.1276791790073; Thu, 17 Jun 2010 09:23:10 -0700 (PDT) Received: by 10.224.37.139 with HTTP; Thu, 17 Jun 2010 09:23:09 -0700 (PDT) In-Reply-To: <20100617.100235.195066307596264499.imp@bsdimp.com> References: <98F8CB29-62FE-41A6-8AE6-6F8AF086D29C@lakerest.net> <20100617.100235.195066307596264499.imp@bsdimp.com> Date: Thu, 17 Jun 2010 21:53:09 +0530 Message-ID: From: "Jayachandran C." To: "M. Warner Losh" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD - part 2 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2010 16:23:11 -0000 On Thu, Jun 17, 2010 at 9:32 PM, M. Warner Losh wrote: > In message: <98F8CB29-62FE-41A6-8AE6-6F8AF086D29C@lakerest.net> > =A0 =A0 =A0 =A0 =A0 =A0Randall Stewart writes: > : JC: > : > : I don't think renaming the PTE entries to PG_ is a good idea. > : > : Way back in 2007 this was one of the issues I hit.. the J code > : used PG_ and somewhere in the VM we used PG_ to indicate (Page). > : > : Thus we ended up with a PG_G defined in two places and we were setting > : PG_G and it was Not the PTE PG_G.. but the one defined in the VM. > > This was a big frustration at the time... =A0I'd somehow blocked it from > my memory when Juli and I talked about this a while ago... > > : The folks in the VM world suggested we change this to PTE_xxx which I > : did. > > Alan Cox, if memory serves. I had tested the changes (buildworld on 32 cpus) , so there is a chance that the problem no longer exists. There is one minor cleanup in the patch that can be done (ie unify the mips_pg and pmap_pte macros). But the renaming itself does not seem to buy us anything. I will wait for Juli's comments too, as she is the original author of the patch... JC. > Warner > > : R > : On Jun 17, 2010, at 11:38 AM, Jayachandran C. wrote: > : > : > On Tue, Jun 15, 2010 at 7:06 PM, Jayachandran C. > : > wrote: > : >> I have volunteered to merge Juli's 64-bit work into HEAD, =A0and > : >> hopefully get it to work on XLR too. The tree > : >> (http://svn.freebsd.org/base/user/jmallett/octeon) has quite a bit o= f > : >> changes, so I would like to do this over multiple changesets and > : >> without breaking the current o32 code. > : > > : > Here's part 2, containing two patches: > : > > : > pmap-PTE-to-PG.patch : > : > > : > This is a renaming patch with minor cleanup, The PTE_* flags are > : > renamed to PG_ and related changes are made to other files. I have > : > tried to make this patch limited to just the renaming and the changes > : > related to it. =A0I will make another patch for the rest of the minor > : > changes in pmap.c. > : > > : > My comment on this patch: The name PG_C_CNC for value 3 in pte.h may > : > be confusing, at least on XLR. We don't have cached non-coherent mode= , > : > the cached memory is coherent(except L1 I-cache), so I would prefer > : > PG_CACHED and PG_UNCACHED names. > : > > : > pmap-lgmem-lock-remove.patch : > : > > : > Remove the lock in local_sysmaps, and sched_pin()/unpin() in the > : > PMAP_LMEM_ macros. > : > > : > The 64-bit support changes would be next - comments on the patches > : > esp. the first one is welcome. > : > > : > Thanks, > : > JC. > : > > : > : ------------------------------ > : Randall Stewart > : 803-317-4952 (cell) > : > : > --=20 C. Jayachandran c.jayachandran@gmail.com