From owner-svn-src-stable-10@freebsd.org Fri Apr 28 20:40:41 2017 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84CD7D5458E; Fri, 28 Apr 2017 20:40:41 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 53E86676; Fri, 28 Apr 2017 20:40:40 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-it0-f43.google.com with SMTP id x188so49824732itb.0; Fri, 28 Apr 2017 13:40:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6zBMw/J04+/bk+DoKEJ6gfYyMX0wo9ucSa6LNJFa8bQ=; b=glOokbT2+dBEjzQGMix+KCCg5PO0Hj92CfdZTiiu+6rPUwLJI0/TLYKi8qGiof4gvz A5V/ZMKQIH716kQ8I7625lFQqy7UNPtTZlKBwZddRNPZpUzvHcQm9hhCJqHThUn9tgC6 UZwjqRy17aKtQTQIG/ydkbfgbqK24V9lLdyOCLZ3ch/y6J26YUGkOksV+ThTYBACcy4y HncClo74HORDKiUpmXVDkZ8pB5ljVScucopMDokzesGcA7VnPECsTdMiiIcgMnIUQ/1w dIMcmx5UkTxowj6U4Igy/THgOQ0vILs5CcpBMP6/iedj3t1TIybH82tGEYqqF1QK/gSg hchA== X-Gm-Message-State: AN3rC/7yACiaQOw2EyDoorIS3NU4iWKGc0ttlDPxvP9fbtB+Sa7B4TTU TFK3zhMK+RBem9m9jfYc0XUi X-Received: by 10.36.51.133 with SMTP id k127mr159917itk.17.1493412039563; Fri, 28 Apr 2017 13:40:39 -0700 (PDT) Received: from mail-it0-f54.google.com (mail-it0-f54.google.com. [209.85.214.54]) by smtp.gmail.com with ESMTPSA id g69sm264987itg.17.2017.04.28.13.40.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 13:40:38 -0700 (PDT) Received: by mail-it0-f54.google.com with SMTP id e65so1046454ita.1; Fri, 28 Apr 2017 13:40:38 -0700 (PDT) X-Received: by 10.202.61.65 with SMTP id k62mr4560405oia.43.1493412038727; Fri, 28 Apr 2017 13:40:38 -0700 (PDT) MIME-Version: 1.0 References: <201703152120.v2FLKHUs052999@repo.freebsd.org> In-Reply-To: From: Eric Joyner Date: Fri, 28 Apr 2017 20:40:28 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv To: Ngie Cooper , Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-10@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 20:40:41 -0000 I notified Jeb (the original patch submitter) about that netmap symbol issue, but we've both been distracted with other development. I'll work on updating it. - Eric On Thu, Apr 27, 2017 at 3:06 PM Ngie Cooper wrote: > On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste wrote: > > On 15 March 2017 at 17:20, Eric Joyner wrote: > >> Author: erj > >> Date: Wed Mar 15 21:20:17 2017 > >> New Revision: 315333 > >> URL: https://svnweb.freebsd.org/changeset/base/315333 > >> > >> Log: > >> ixgbe(4): Update to 3.2.11-k > > > > This broke tinderbox on many architectures: > > > > ia64 GENERIC and powerpc GENERIC64: > > > > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no > > previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes] > > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no > > previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes] > > > > sparc64 LINT: > > > > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning: > > redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls] > > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning: > > previous declaration of 'ix_crcstrip' was here > > > > amd64 LINT: > > > > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0): > > multiple definition of `ixgbe_netmap_attach' > > > ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0): > > first defined here > > Hi Ed, > > It has to do with netmap(4) refactoring on head not being backported, > in combination with ixgbe/ix being MFCed in a refactored state back to > ^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on > ^/stable/10 -- I tried starting this work and failed because I lacked > the hardware to test this out with). > > This has been known to be broken for almost two months -- a surgical > fix should probably be applied to do what's required to make the > symbol appear in the appropriate places, since this basically was a > direct commit to ^/stable/10 in some regards. > > Thanks, > -Ngie >