From owner-svn-ports-head@freebsd.org Sun Jul 29 15:50:20 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99B541059CE2; Sun, 29 Jul 2018 15:50:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3C59884B0E; Sun, 29 Jul 2018 15:50:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (unknown [IPv6:2601:648:8880:1e30:d0ee:a17a:5c15:3465]) by mail.baldwin.cx (Postfix) with ESMTPSA id 287BB10A87D; Sun, 29 Jul 2018 11:50:19 -0400 (EDT) Subject: Re: [toolchain] svn commit: r474650 - in head/lang: . gcc8 [ not added to bsd.gcc.mk nor to the comment in bsd.default-versions.mk ] To: Gerald Pfeifer , Mark Millard , svn-ports-head@freebsd.org References: <56DFBA7C-9527-4EB5-9C6F-1F56945F9F3C@yahoo.com> Cc: freebsd-toolchain@freebsd.org From: John Baldwin Message-ID: <86ee3299-0da5-59a0-d808-99357883bd94@FreeBSD.org> Date: Sun, 29 Jul 2018 08:50:19 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Sun, 29 Jul 2018 11:50:19 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 15:50:20 -0000 On 7/28/18 8:05 AM, Gerald Pfeifer wrote: > On Sun, 15 Jul 2018, Gerald Pfeifer wrote: >>> https://svnweb.freebsd.org/ports/head/Mk/bsd.default-versions.mk : >>> >>> # Possible values: 4.9, 5, 6, 7 >>> GCC_DEFAULT?= 6 >> Given that this is still the first release of the GCC 8 series, >> I'm a bit hesitant to add it there. Too many folks too eager >> running into problems and then not knowing how to go about it. >> >> I'd rather wait for GCC 8.2 which is due this summer. > > With GCC 8.2 out now (and hence also the fix of an minor C++ > ABI bug introduced with GCC 8.1) I have now made this change > to Mk/bsd.default-versions.mk. > > > If anyone can help me with the finishing touches of changed the > default to GCC 7 and start working on GCC 8, that would be great > and much appreciated! One random thing to consider that is GCC related. For FreeBSD 12.0 and later we are planning to use init_array and fini_array instead of ctors/dtors for lists of constructor and destructor functions. clang in head has already been changed to do this, and I've patched the external toolchain versions of GCC in devel/*-gcc and base/gcc to do this. lang/gcc* should also probably be patched with a similar patch to what I used in base/gcc to enable it based on OSVERSION: --- head/base/gcc/Makefile 2018/06/08 16:06:49 472012 +++ head/base/gcc/Makefile 2018/07/11 16:50:00 474469 @@ -2,6 +2,7 @@ PORTNAME= gcc PORTVERSION= 6.4.0 +PORTREVISION= 1 CATEGORIES= base MASTER_SITES= GCC/releases/gcc-${DISTVERSION} \ http://www.mpfr.org/mpfr-3.1.6/:mpfr \ @@ -61,6 +62,10 @@ INSTALL_TARGET?= install-gcc .include +.if ${OSVERSION} >= 1200000 +CONFIGURE_ARGS+= --enable-initfini-array +.endif + .if ${ARCH:Mmips*} PLIST_SUB+= MIPS="" .else -- John Baldwin