From owner-svn-src-all@FreeBSD.ORG Sat Feb 14 00:05:43 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 99A39389; Sat, 14 Feb 2015 00:05:43 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 218C4EDB; Sat, 14 Feb 2015 00:05:42 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1E05emp034273 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 14 Feb 2015 03:05:40 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1E05eut034272; Sat, 14 Feb 2015 03:05:40 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 14 Feb 2015 03:05:40 +0300 From: Gleb Smirnoff To: julian@FreeBSD.org, mav@FreeBSD.org Subject: Re: svn commit: r278640 - head/sys/netgraph Message-ID: <20150214000540.GI15484@FreeBSD.org> References: <201502122220.t1CMKY8t040498@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201502122220.t1CMKY8t040498@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2015 00:05:43 -0000 Hi! On Thu, Feb 12, 2015 at 10:20:34PM +0000, Gleb Smirnoff wrote: T> Author: glebius T> Date: Thu Feb 12 22:20:34 2015 T> New Revision: 278640 T> URL: https://svnweb.freebsd.org/changeset/base/278640 T> T> Log: T> Revise default limit for maximum of netgraph data items. T> With modern internet speeds the limit can be reached even T> on a single L2TP link. Actually any ng_item of data type requires an mbuf to be connected to it, and thus I suggest to use mbuf limits to drive ng_item limits. If we got an item leak with mbufs being properly freed, then we've got a bug to fix, and any limit won't work in long run time. I never evidenced such a bug, but there complaints on hitting limit at traffic bursts. As said, with previous 512 item limit I experienced that even on a laptop. Any objections on removing the limit, guys? T> Modified: T> head/sys/netgraph/ng_base.c T> T> Modified: head/sys/netgraph/ng_base.c T> ============================================================================== T> --- head/sys/netgraph/ng_base.c Thu Feb 12 21:20:28 2015 (r278639) T> +++ head/sys/netgraph/ng_base.c Thu Feb 12 22:20:34 2015 (r278640) T> @@ -2952,7 +2952,7 @@ uma_zone_t ng_qzone; T> uma_zone_t ng_qdzone; T> static int numthreads = 0; /* number of queue threads */ T> static int maxalloc = 4096;/* limit the damage of a leak */ T> -static int maxdata = 512; /* limit the damage of a DoS */ T> +static int maxdata = 4096; /* limit the damage of a DoS */ T> T> SYSCTL_INT(_net_graph, OID_AUTO, threads, CTLFLAG_RDTUN, &numthreads, T> 0, "Number of queue processing threads"); T> -- Totus tuus, Glebius.