From owner-freebsd-hackers@FreeBSD.ORG Fri Oct 22 07:50:08 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17DD9106566B for ; Fri, 22 Oct 2010 07:50:08 +0000 (UTC) (envelope-from guru@unixarea.de) Received: from ms16-1.1blu.de (ms16-1.1blu.de [89.202.0.34]) by mx1.freebsd.org (Postfix) with ESMTP id 933728FC0A for ; Fri, 22 Oct 2010 07:50:07 +0000 (UTC) Received: from [193.31.11.193] (helo=current.Sisis.de) by ms16-1.1blu.de with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1P9CO4-0007EV-Bc; Fri, 22 Oct 2010 09:50:05 +0200 Received: from current.Sisis.de (current [127.0.0.1]) by current.Sisis.de (8.14.3/8.14.3) with ESMTP id o9M7o6UW002409; Fri, 22 Oct 2010 09:50:06 +0200 (CEST) (envelope-from guru@unixarea.de) Received: (from guru@localhost) by current.Sisis.de (8.14.3/8.14.3/Submit) id o9M7o6Ul002408; Fri, 22 Oct 2010 09:50:06 +0200 (CEST) (envelope-from guru@unixarea.de) X-Authentication-Warning: current.Sisis.de: guru set sender to guru@unixarea.de using -f Date: Fri, 22 Oct 2010 09:50:06 +0200 From: Matthias Apitz To: Paul B Mahol , freebsd-hackers@freebsd.org Message-ID: <20101022075006.GA2377@current.Sisis.de> References: <20101021141206.GA37339@current.Sisis.de> <20101021184149.GA1142@tiny> <20101022071403.GA2152@current.Sisis.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20101022071403.GA2152@current.Sisis.de> X-Operating-System: FreeBSD 8.0-CURRENT (i386) User-Agent: Mutt/1.5.19 (2009-01-05) X-Con-Id: 51246 X-Originating-IP: 193.31.11.193 Cc: Pyun YongHyeon Subject: Re: kmod if_alc in 8-CURRENT X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthias Apitz List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2010 07:50:08 -0000 El día Friday, October 22, 2010 a las 09:14:03AM +0200, Matthias Apitz escribió: > # make > Warning: Object directory not changed from original > /usr/src/sys/modules/alc > cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE > -nostdinc -I. -I@ -I@/contrib/altq -finli > ne-limit=8000 --param inline-unit-growth=100 --param > large-function-growth=1000 -fno-common -mno-align-long > -strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse > -mno-sse2 -mno-sse3 -ffreestanding -fsta > ck-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls > -Wnested-externs -Wstrict-prototype > s -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > -Wno-pointer-sign -fformat-extensions > -c /usr/src/sys/modules/alc/../../dev/alc/if_alc.c > cc1: warnings being treated as errors > /usr/src/sys/modules/alc/../../dev/alc/if_alc.c: In function > 'alc_rxfilter': > /usr/src/sys/modules/alc/../../dev/alc/if_alc.c:3465: warning: implicit > declaration of function 'if_maddr_rl > ock' > /usr/src/sys/modules/alc/../../dev/alc/if_alc.c:3465: warning: nested > extern declaration of 'if_maddr_rlock' > /usr/src/sys/modules/alc/../../dev/alc/if_alc.c:3473: warning: implicit > declaration of function 'if_maddr_ru > nlock' > /usr/src/sys/modules/alc/../../dev/alc/if_alc.c:3473: warning: nested > extern declaration of 'if_maddr_runloc > k' > *** Error code 1 The change was introduced with rev. 1.2 of the driver: revision 1.2 date: 2009/06/26 11:45:06; author: rwatson; state: Exp; lines: +2 -2 SVN rev 195049 on 2009-06-26 11:45:06Z by rwatson Use if_maddr_rlock()/if_maddr_runlock() rather than IF_ADDR_LOCK()/ IF_ADDR_UNLOCK() across network device drivers when accessing the per-interface multicast address list, if_multiaddrs. This will allow us to change the locking strategy without affecting our driver programming interface or binary interface. and I checked out RELENG_8_0_0_RELEASE (revision: 1.3.2.2.2.1) will Cc: the author to see what I should do with my 8-CURRENT from May 2009 to get support for this NIC; Thanks matthias -- Matthias Apitz t +49-89-61308 351 - f +49-89-61308 399 - m +49-170-4527211 e - w http://www.unixarea.de/