From owner-freebsd-scsi@FreeBSD.ORG  Wed Jul 11 19:16:50 2012
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AB9B2106564A
	for <freebsd-scsi@freebsd.org>; Wed, 11 Jul 2012 19:16:50 +0000 (UTC)
	(envelope-from seanbru@yahoo-inc.com)
Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com
	[98.139.253.104])
	by mx1.freebsd.org (Postfix) with ESMTP id 534B18FC0C
	for <freebsd-scsi@freebsd.org>; Wed, 11 Jul 2012 19:16:50 +0000 (UTC)
Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231])
	by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id
	q6BJFAcl071531; Wed, 11 Jul 2012 12:15:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com;
	s=cobra; t=1342034111;
	bh=1h3eMI1x901TVG0MwmLxi4I5jYozgIxAUZqM9PPB5pA=;
	h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date:
	Message-ID:Mime-Version:Content-Transfer-Encoding;
	b=J9qdMWHqvUn2WNrrMKbjDCbNpilJRGQgLP7va64NgBIL8ufc4433VjDTiAnTpNYm3
	4VkHOdUSyoHgWnLeR+FGI8Tqw0wWJtFIiSzTMXpncDBdSrWzw8X8wLOs3Zm16IUPMA
	q+c5IkP12O0cjg+22i9aZIRTsFBrfHr/SYLdbQRA=
From: Sean Bruno <seanbru@yahoo-inc.com>
To: Andrew Boyer <aboyer@averesystems.com>
In-Reply-To: <A97A39B9-7B2C-4553-874D-6D030EDDE4A1@averesystems.com>
References: <A97A39B9-7B2C-4553-874D-6D030EDDE4A1@averesystems.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 11 Jul 2012 12:15:09 -0700
Message-ID: <1342034109.9662.7.camel@powernoodle.corp.yahoo.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
X-Milter-Version: master.31+4-gbc07cd5+
X-CLX-ID: 034110001
Cc: "freebsd-scsi@freebsd.org" <freebsd-scsi@freebsd.org>
Subject: Re: [patch] MFI mfivar.h needs to include the option header
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jul 2012 19:16:50 -0000

On Tue, 2012-07-10 at 09:43 -0700, Andrew Boyer wrote:
> sys/dev/mfivar.h contains references to MFI_DEBUG, but it never gets turned on unless the file also includes opt_mfi.h.
> 
> -Andrew
> 
> Index: sys/dev/mfi/mfivar.h
> ===================================================================
> --- sys/dev/mfi/mfivar.h	(revision 238348)
> +++ sys/dev/mfi/mfivar.h	(working copy)
> @@ -61,6 +61,7 @@
>  
>  #include <sys/types.h>
>  #include <sys/taskqueue.h>
> +#include "opt_mfi.h"
>  
>  /*
>   * SCSI structures and definitions are used from here, but no linking
> 
> --------------------------------------------------
> Andrew Boyer	aboyer@averesystems.com
> 

Committed at svn r238373

Sean