From owner-svn-src-head@freebsd.org Mon Feb 4 21:12:17 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5ACDC14B352D; Mon, 4 Feb 2019 21:12:17 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it1-f171.google.com (mail-it1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 841C272B27; Mon, 4 Feb 2019 21:12:16 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it1-f171.google.com with SMTP id b5so3341458iti.2; Mon, 04 Feb 2019 13:12:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0wxMCkLIcaTvguxmnyDl8RLFDalRKV1AccSSf5+hoxU=; b=PAjRY5Iw6dFRRypneI7NA38w6hKcjCVfUAeTNcczjlz9FbmLpVLdkjiDZviaQUJcJV m70rrNVWKMPL6+3TKJjie3c+kED7hR0mCB/h4hpsndNYZW3/xfVwKnyrlkGDCyckg70e f3GS7c2HD41uS0tkSGdi4hG937KJydKHbiRxWnhoHTj90V4ZfBCowOZag+nfNIghb7bK HZffTFZ+ysqWqFX/Gap1w6m33q3bDCjKvDDRKJd7sqiFpQwDa3ycpY1DsHX2sZGBrHUl sTMBX/CYzSHKjkuMHJoBK/M2MBuKcPJ/dSgn1FyxzpZmDCt7xjgM2BhVpHK1YkcJO9nW 6Ykw== X-Gm-Message-State: AHQUAua19B5lOUQu5J7iBr1gGbuhOEdDoFMlGEVn9rSJ5d3gYrWUl078 wXw6QxCohCHBoJJ4xKMmh9pRRMbGXIwEqgwY5mWVukli X-Google-Smtp-Source: AHgI3IYP25EMealS1zFKm2ECPTHLRXCYXkqhu3hUbC2Gc67AQg11HmRY0/V4Icl0+9pledSN+tfMa2gtbgK9d7F9jVk= X-Received: by 2002:a24:8ac7:: with SMTP id v190mr767933itd.174.1549314357263; Mon, 04 Feb 2019 13:05:57 -0800 (PST) MIME-Version: 1.0 References: <201711112330.vABNUwXC077395@repo.freebsd.org> In-Reply-To: <201711112330.vABNUwXC077395@repo.freebsd.org> From: Ed Maste Date: Mon, 4 Feb 2019 16:05:45 -0500 Message-ID: Subject: Re: svn commit: r325728 - head/lib/libkvm To: Will Andrews Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 841C272B27 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-5.72 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.87)[-0.870,0]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[171.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.84)[ip: (-8.41), ipnet: 209.85.128.0/17(-3.76), asn: 15169(-1.94), country: US(-0.07)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 21:12:17 -0000 On Sat, 11 Nov 2017 at 18:31, Will Andrews wrote: > > Author: will > Date: Sat Nov 11 23:30:58 2017 > New Revision: 325728 > URL: https://svnweb.freebsd.org/changeset/base/325728 > > Log: > libkvm: add kvm_walk_pages API. > > Modified: head/lib/libkvm/kvm.h > ============================================================================== > --- head/lib/libkvm/kvm.h Sat Nov 11 22:50:14 2017 (r325727) > +++ head/lib/libkvm/kvm.h Sat Nov 11 23:30:58 2017 (r325728) > @@ -36,6 +36,7 @@ > #include > #include > #include > +#include > > /* Default version symbol. */ > #define VRS_SYM "_version" > @@ -73,7 +74,19 @@ struct kvm_swap { > u_int ksw_reserved2; > }; > > +struct kvm_page { > + unsigned int version; > + u_long paddr; This should probably be uin64_t to support cross-debugging cores from 64-bit machines on 32-bit hosts; also for i386 PAE. Or, on IRC jhb suggested we introduce a kpaddr_t typedef akin to kvaddr_t. > + u_long kmap_vaddr; > + u_long dmap_vaddr; These two should be kvaddr_t. > + vm_prot_t prot; > + u_long offset; off_t? > + size_t len; > + /* end of version 1 */ > +}; > + > #define SWIF_DEV_PREFIX 0x0002 > +#define LIBKVM_WALK_PAGES_VERSION 1