From owner-freebsd-current@freebsd.org Fri Apr 7 21:50:33 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E11FD33430 for ; Fri, 7 Apr 2017 21:50:33 +0000 (UTC) (envelope-from tommi.pernila@gmail.com) Received: from mail-qk0-x22f.google.com (mail-qk0-x22f.google.com [IPv6:2607:f8b0:400d:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DE354C7D for ; Fri, 7 Apr 2017 21:50:32 +0000 (UTC) (envelope-from tommi.pernila@gmail.com) Received: by mail-qk0-x22f.google.com with SMTP id f133so56577139qke.2 for ; Fri, 07 Apr 2017 14:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=I/PsMwpX8rEAViC9EDio3e12pmHR5qlKNdRtQTvag5M=; b=g/2gTxZjnugMSfxtzJxPVteDez36sa60mKQeq6QCOBq1cw0R+mVtlSiexLWIcQk6QR BKzrmEkrpLiS8s65k3zsEdEdc1IFazgZI3bcphDoZwAcM8q3egGjOjD1SszST50a/LmR HRz8Hf3sXgnNFsgGpTH88SoTDb4owds0hYItdhgdJG0k/XMigum/OislSmem0EJ2k1N3 j3AW0c7s387VO9zYzGyo/rLqzTDuc7VDDDfYXHr7Wi6xgtaCicrOIOOFUShRN6CaB8VA C47rtVmPAUdwbZbCXPXw+dIjgmzK86kALKui1sg+eIy6iSKcopGq5ANVwm09jQffQTeF 94iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=I/PsMwpX8rEAViC9EDio3e12pmHR5qlKNdRtQTvag5M=; b=BtU1Jc4Y4lq76rcjsx5jTyWuOckKCiV4PXjI1XjOsorrSQshSazlesqwPi4tfB+VQ3 3LwUvYIi5QRBHqzz2ZiyWifAjH7/4358VUeVpGrWunLkEuXmTXFNmsy5NTuyCOohxU0I cai852jKjm1upnux19ZN+fO/VB0+TvJJZ8Yb+uT5Fdj7WRd4dve7yrA4W26hn+Peb093 9xPVqZMnVgDaY7H22hVJF94Le4ohyeuosOEy+w7QfuV2wT4xesRsHiJ2AQo9ja/6BRZo CFr3GcrISbfcsZy7NOgx+8OSGk42wP/P7sg+ArJE6w5TEl6JicA7rkJcitwFKE+j43gA QAgA== X-Gm-Message-State: AFeK/H3paxLTpNDg+wbnEY7Ea6In2sT84DMTfE8OAQwrKS7wU3BiHLXt/ejrJlCY/1imsmr/1+eK/GgdcDncVg== X-Received: by 10.55.178.133 with SMTP id b127mr38377974qkf.170.1491601831693; Fri, 07 Apr 2017 14:50:31 -0700 (PDT) MIME-Version: 1.0 Sender: tommi.pernila@gmail.com Received: by 10.200.42.163 with HTTP; Fri, 7 Apr 2017 14:50:31 -0700 (PDT) From: Tommi Pernila Date: Sat, 8 Apr 2017 00:50:31 +0300 X-Google-Sender-Auth: xTItl-gfGxtdqHrdVFntM1WoMU0 Message-ID: Subject: PVS-Studio Analyzer Spots Bugs In the FreeBSD 2017 edition To: freebsd-current Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 21:50:33 -0000 Hi all, just a heads up if you haven't yet seen this blog post from Andrey Karpov from PVS-Studio. It's a quite a long read. https://www.viva64.com/en/b/0496/ Here's a few highlights (with some paraphrasing). >PVS-Studio fixed errors where it's clear how to fix them without digging deep into the algorithms. >That's why FreeBSD authors should really do a deeper analysis themselves, >not just review that limited number of errors that we presented. >Andrey Karpov is ready to provide a temporary license key and also help to eliminate false positives that may hinder their work. Anyone up for this task? >FreeBSD code is regularly checked by Coverity (which is now a part of Synopsys). >Still, it didn't prevent me from finding 56 potential vulnerabilities and 10 more real bugs in one evening by running PVS-Studio on this code. Br, Tommi