Date: Thu, 30 Mar 2017 16:42:09 +0200 From: Torsten Zuehlsdorff <tz@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437295 - in head/devel: . phpunit6 Message-ID: <94f5e256-650d-3d9e-2e40-35f437568d4f@FreeBSD.org> In-Reply-To: <94e11dc0-7b56-f109-030a-417cb37aeed5@FreeBSD.org> References: <201703301407.v2UE7Sfg097668@repo.freebsd.org> <f7088916-1202-c86d-acd3-ffa2516c61d1@FreeBSD.org> <0d844417-76ff-9c6f-83ad-6ed9c3b7f598@FreeBSD.org> <94e11dc0-7b56-f109-030a-417cb37aeed5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30.03.2017 16:40, Mathieu Arnold wrote: > Le 30/03/2017 à 16:35, Torsten Zuehlsdorff a écrit : >> >> >> On 30.03.2017 16:31, Mathieu Arnold wrote: >>> Le 30/03/2017 à 16:07, Torsten Zuehlsdorff a écrit : >>>> SUBDIR += phpunit >>>> + SUBDIR += phpunit6 >>>> >>> >>> Please remove and add it back using devel/phpunit as a base. (Also, >>> don't throw away the two changes I made to the port.) >> >> No, this would render devel/phpunit unusable at the current status. I >> added a notice, that phpunit6 requires PHP 7.0. It refuses to work >> with PHP 5.6. Since PHP 5.6 is our default version, this will make >> phpunit stop working. >> >> My current plan is to work at bumping PHP 7.0 as our default and than >> do your required changes. >> >> Objections? > > I'll write this again. > > phpunit6 the same software as phpunit, but it is a new version. > When adding a new version of some software already in the ports tree, it > *must* be added as a copy of the previous version of the software, and > then the files updated to reflect the fact that it is a newer version. > While doing that, you must not forget that two ports must not have the > same package name (make -V PKGBASE) so you must add a PKGNAMESUFFIX > variable to reflect that. Okay, i understand this and will do. But you left out the point, that the new version is unable to run at PHP 5.6 and therefore should require a PHP version. Greetings, Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?94f5e256-650d-3d9e-2e40-35f437568d4f>