From owner-svn-ports-all@freebsd.org Thu Mar 30 14:42:11 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A357CD24244; Thu, 30 Mar 2017 14:42:11 +0000 (UTC) (envelope-from tz@FreeBSD.org) Received: from toco-domains.de (mail.toco-domains.de [IPv6:2a01:4f8:150:50a5::6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6F931BBB; Thu, 30 Mar 2017 14:42:11 +0000 (UTC) (envelope-from tz@FreeBSD.org) Received: from [0.0.0.0] (mail.toco-domains.de [IPv6:2a01:4f8:150:50a5::6]) by toco-domains.de (Postfix) with ESMTPA id E15371AAF058; Thu, 30 Mar 2017 16:42:09 +0200 (CEST) Subject: Re: svn commit: r437295 - in head/devel: . phpunit6 To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201703301407.v2UE7Sfg097668@repo.freebsd.org> <0d844417-76ff-9c6f-83ad-6ed9c3b7f598@FreeBSD.org> <94e11dc0-7b56-f109-030a-417cb37aeed5@FreeBSD.org> From: Torsten Zuehlsdorff Message-ID: <94f5e256-650d-3d9e-2e40-35f437568d4f@FreeBSD.org> Date: Thu, 30 Mar 2017 16:42:09 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <94e11dc0-7b56-f109-030a-417cb37aeed5@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 14:42:11 -0000 On 30.03.2017 16:40, Mathieu Arnold wrote: > Le 30/03/2017 à 16:35, Torsten Zuehlsdorff a écrit : >> >> >> On 30.03.2017 16:31, Mathieu Arnold wrote: >>> Le 30/03/2017 à 16:07, Torsten Zuehlsdorff a écrit : >>>> SUBDIR += phpunit >>>> + SUBDIR += phpunit6 >>>> >>> >>> Please remove and add it back using devel/phpunit as a base. (Also, >>> don't throw away the two changes I made to the port.) >> >> No, this would render devel/phpunit unusable at the current status. I >> added a notice, that phpunit6 requires PHP 7.0. It refuses to work >> with PHP 5.6. Since PHP 5.6 is our default version, this will make >> phpunit stop working. >> >> My current plan is to work at bumping PHP 7.0 as our default and than >> do your required changes. >> >> Objections? > > I'll write this again. > > phpunit6 the same software as phpunit, but it is a new version. > When adding a new version of some software already in the ports tree, it > *must* be added as a copy of the previous version of the software, and > then the files updated to reflect the fact that it is a newer version. > While doing that, you must not forget that two ports must not have the > same package name (make -V PKGBASE) so you must add a PKGNAMESUFFIX > variable to reflect that. Okay, i understand this and will do. But you left out the point, that the new version is unable to run at PHP 5.6 and therefore should require a PHP version. Greetings, Torsten