From owner-svn-ports-head@freebsd.org  Wed May 20 15:10:42 2020
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F6C92DC61C;
 Wed, 20 May 2020 15:10:42 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 49Rx5Z1XX4z4KQy;
 Wed, 20 May 2020 15:10:42 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from beaver (unknown [81.6.39.88])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate) (Authenticated sender: ehaupt)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 4579A36EA9;
 Wed, 20 May 2020 15:10:41 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Date: Wed, 20 May 2020 17:10:39 +0200
From: Emanuel Haupt <ehaupt@FreeBSD.org>
To: Mathieu Arnold <mat@freebsd.org>
Cc: Emanuel Haupt <ehaupt@freebsd.org>, Hiroki Tagato
 <tagattie@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, koobs@freebsd.org
Subject: Re: svn commit: r535526 - in head: . sysutils
 sysutils/py-rdiff-backup sysutils/py-rdiff-backup/files
 sysutils/rdiff-backup
Message-Id: <20200520171039.680fd46e6d1180796c50042d@FreeBSD.org>
In-Reply-To: <20200520150415.yn3cc6ebghlf6bpt@aching.in.mat.cc>
References: <202005170835.04H8ZKws029186@repo.freebsd.org>
 <20200520143655.rvvwajvklbkzyvdz@aching.in.mat.cc>
 <20200520165905.114abeca25f06c90b71f3945@FreeBSD.org>
 <20200520150415.yn3cc6ebghlf6bpt@aching.in.mat.cc>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 May 2020 15:10:42 -0000

Mathieu Arnold <mat@freebsd.org> wrote:
> On Wed, May 20, 2020 at 04:59:05PM +0200, Emanuel Haupt wrote:
> > Mathieu Arnold <mat@freebsd.org> wrote:
> > > On Sun, May 17, 2020 at 08:35:20AM +0000, Hiroki Tagato wrote:
> > > >   - Rename portname to py-rdiff-backup following Python Ports
> > > > Policy[1]
> > > 
> > > This feels like a very bad idea, for more than one reason.
> > 
> > This was reviewed in (you subscribed too):
> > 
> > https://reviews.freebsd.org/D24816
> > 
> > > - This renamed the package, so once again, it left users running
> > > pkg upgrade with an outdated version.  Unless they notice it and
> > > figure out what the new name of the port is.
> > > - This looks like a end user tool, so, people will want to install
> > >   rdiff-backup, not pyxy-rdiff-backup.
> > > 
> > > All in all, I think the rename should be backed out.
> > 
> > koobs reasoning made sense to me but I don't mind renaming the port
> > again if there is a final consensus.
> 
> I don't know the reasoning, but anything that 1) breaks the normal
> upgrade path, and 2) makes it non trivial to figure out the name of
> the package, must have a flaw somewhere.

The detailed reasoning is in the review, search for "On naming (py- or
not)"