From owner-svn-src-head@freebsd.org  Sun Nov 29 22:39:47 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BDBCA3C540;
 Sun, 29 Nov 2015 22:39:47 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "tensor.andric.com",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5E61D1F06;
 Sun, 29 Nov 2015 22:39:47 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from [IPv6:2001:7b8:3a7::e81c:127:3e7b:39b6] (unknown
 [IPv6:2001:7b8:3a7:0:e81c:127:3e7b:39b6])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 1995B335FB;
 Sun, 29 Nov 2015 23:39:44 +0100 (CET)
Subject: Re: svn commit: r291453 - head/lib/libfetch
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
Content-Type: multipart/signed;
 boundary="Apple-Mail=_E57B482F-12C1-45CD-BD65-1D7EA79FD5ED";
 protocol="application/pgp-signature"; micalg=pgp-sha1
X-Pgp-Agent: GPGMail 2.6b2
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <CABW2x9oSjevQswLGworjomQMTKeZfjt2EE9ZC2WD8bThsR=DpQ@mail.gmail.com>
Date: Sun, 29 Nov 2015 23:39:35 +0100
Cc: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Message-Id: <0BD9830A-9592-46AD-B626-4E75948C8A2A@FreeBSD.org>
References: <201511291427.tATER0lb011244@repo.freebsd.org>
 <CABW2x9oSjevQswLGworjomQMTKeZfjt2EE9ZC2WD8bThsR=DpQ@mail.gmail.com>
To: Jason Unovitch <jason.unovitch@gmail.com>
X-Mailer: Apple Mail (2.3096.5)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Nov 2015 22:39:47 -0000


--Apple-Mail=_E57B482F-12C1-45CD-BD65-1D7EA79FD5ED
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On 29 Nov 2015, at 18:35, Jason Unovitch <jason.unovitch@gmail.com> =
wrote:
>=20
> On Sun, Nov 29, 2015 at 9:27 AM, Dag-Erling Sm=C3=B8rgrav =
<des@freebsd.org> wrote:
>> Author: des
>> Date: Sun Nov 29 14:26:59 2015
>> New Revision: 291453
>> URL: https://svnweb.freebsd.org/changeset/base/291453
...
> `make buildworld` fails after this commit:
>=20
> /usr/src/head/lib/libfetch/http.c:1692:25: error: address of array
> 'url->user' will always evaluate to 'true' [-Werro
> r,-Wpointer-bool-conversion]
>                                aparams.user =3D url->user ?
>                                               ~~~~~^~~~ ~
> /usr/src/head/lib/libfetch/http.c:1694:29: error: address of array
> 'url->pwd' will always evaluate to 'true' [-Werror
> ,-Wpointer-bool-conversion]
>                                aparams.password =3D url->pwd ?

This should now be fixed by r291461.

-Dimitry


--Apple-Mail=_E57B482F-12C1-45CD-BD65-1D7EA79FD5ED
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.28

iEYEARECAAYFAlZbfq8ACgkQsF6jCi4glqNiRACeNGyL7yFUafQBmpBYampgbDPD
uWsAoO7m2fYeqC+/mubj4alfWqeteU/N
=ImJM
-----END PGP SIGNATURE-----

--Apple-Mail=_E57B482F-12C1-45CD-BD65-1D7EA79FD5ED--