From owner-freebsd-current@freebsd.org Fri Nov 23 13:21:50 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2EEF41146BA7 for ; Fri, 23 Nov 2018 13:21:50 +0000 (UTC) (envelope-from samy.mahmoudi@gmail.com) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 59FC28986C; Fri, 23 Nov 2018 13:21:49 +0000 (UTC) (envelope-from samy.mahmoudi@gmail.com) Received: by mail-lf1-x12e.google.com with SMTP id z13so8708417lfe.11; Fri, 23 Nov 2018 05:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a2dXWGi1RIb8LCfXNIgwjt1Mdv9+nnQAYoUmlZJ8pmk=; b=DhyVaC1GsdZqCdvo/6fYZlxQ5YSDJ3pgkOlDOZHnkJSjnvEknXAT/MYLiwleeHUubh weRnQHWSvaRIvHrjy4g8U+tDcmkvPYIOw609GVp4DXU9Md51UBTjvmOhHJZuvGiQPoj8 DrqGUi4G/1AWPiua7stYfPvo+oYCCz58dMazjngYoX6AyJRJLJIJjJF9eqVvz3R80jyJ HuFJFQKEro5jOhzLVCNoDcPP1omBsYRPgI5+jy1+212k6P3VS1RMBqMCEH/aiz7BCAKK Jps1A+2m1gVWyvc/OHprQu0yU4aSpmXMAITtkDEhDy2FzCjtMe/NYdqfr271BFowRI4E oukQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a2dXWGi1RIb8LCfXNIgwjt1Mdv9+nnQAYoUmlZJ8pmk=; b=aOYLqV+fyhfSErVovjeuNR0DQUScoWFQ+9OWxPIIsscB3ICP/3d+Po0gIu4H+/mx5/ rrDSHUlyb7ncdGZHnczkEWMnXt0DCtWQ7nnjjMlu2xORrDpl76hSRolZKWzGvifu/Gow NXjMb092EF5VoiVFyIeKVLNg5dFsrNzVQ4KJefP2rjWMxvtBlLjSTQnKSmybn4Vz4sd3 T4TPyogRycPGz/7A8rasDgydyGMZHynwqQFgDYm52ok8S8Kokc3D3zteIFsdvmf5mvWi C/Iq2/8TR/oSFRdT/1uzLK8kQ7IZbjL/SXPhTRGuMnubVBkKs2jyNU6IXGvhEfRGierz v8ww== X-Gm-Message-State: AGRZ1gKQqvdNebvWD5VDaJO/xOT2p8YqfRfrNLpyfMNWFEOAFZ17mIXA jQQtnM1YGke6KUYBWl3qQeldWwwF2DhpqVn27mcabQ/W31c= X-Google-Smtp-Source: AJdET5dH4ZO9z501bwd7h6PzEvxRuSuhQs+TKpHLNl0HaMKaylWk2eA8RuuqfnaS+HhosxHGlERzbwsvPIi5QIyAn0E= X-Received: by 2002:a19:cb94:: with SMTP id b142mr9684518lfg.117.1542979307348; Fri, 23 Nov 2018 05:21:47 -0800 (PST) MIME-Version: 1.0 References: <75fb681f321cd2913f17e8eceffa4cb9@pizarro.net> <20181123050201.63kv32vnjomkeqid@smtp.freebsd.org> In-Reply-To: <20181123050201.63kv32vnjomkeqid@smtp.freebsd.org> From: Samy Mahmoudi Date: Fri, 23 Nov 2018 14:21:33 +0100 Message-ID: Subject: Re: ACPI Error: No handler for Region [ECOR] To: bwidawsk@freebsd.org Cc: matias@pizarro.net, freebsd-current@freebsd.org X-Rspamd-Queue-Id: 59FC28986C X-Spamd-Result: default: False [-4.63 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[e.2.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; IP_SCORE(-0.64)[ipnet: 2a00:1450::/32(-1.60), asn: 15169(-1.50), country: US(-0.09)]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 13:21:50 -0000 Hi all, "patch -p 1 < your_patch" gives me the following *.rej file: @@ -362,7 +362,8 @@ ret = 0; goto out; - } + } else + ecdt = 0; ret = ACPI_ID_PROBE(device_get_parent(dev), dev, ec_ids, NULL); if (ret > 0) @@ -422,16 +434,6 @@ /* Store the values we got from the namespace for attach. */ acpi_set_private(dev, params); - /* - * Check for a duplicate probe. This can happen when a probe via ECDT - * succeeded already. If this is a duplicate, disable this device. - */ - peer = devclass_get_device(acpi_ec_devclass, params->uid); - if (peer == NULL || !device_is_alive(peer)) - ret = 0; - else - device_disable(dev); - if (buf.Pointer) AcpiOsFree(buf.Pointer); out: Reject of hunk 1 and hunk 3 may be due to indentation. Anyway, I manually patched these two parts and I am now waiting for kernel build.