From owner-freebsd-bugs  Wed Jul 12 23:20:13 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 8219237B9E0
	for <freebsd-bugs@FreeBSD.org>; Wed, 12 Jul 2000 23:20:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id XAA78563;
	Wed, 12 Jul 2000 23:20:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from ns.itga.com.au (ns.itga.com.au [202.53.40.210])
	by hub.freebsd.org (Postfix) with ESMTP id 1D6DF37C2F4
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 12 Jul 2000 23:12:20 -0700 (PDT)
	(envelope-from gnb@itga.com.au)
Received: from lightning.itga.com.au (lightning.itga.com.au [192.168.71.20])
	by ns.itga.com.au (8.9.3/8.9.3) with ESMTP id QAA67484
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 Jul 2000 16:12:13 +1000 (EST)
	(envelope-from gnb@itga.com.au)
Received: from hellcat.itga.com.au (hellcat.itga.com.au [192.168.71.163])
	by lightning.itga.com.au (8.9.3/8.9.3) with ESMTP id QAA08807;
	Thu, 13 Jul 2000 16:12:12 +1000 (EST)
Received: (from gnb@localhost)
	by hellcat.itga.com.au (8.9.3/8.9.3) id QAA75928;
	Thu, 13 Jul 2000 16:12:12 +1000 (EST)
	(envelope-from gnb@itga.com.au)
Message-Id: <200007130612.QAA75928@hellcat.itga.com.au>
Date: Thu, 13 Jul 2000 16:12:12 +1000 (EST)
From: Gregory Bond <gnb@itga.com.au>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/19886: skey won't work for usernames > 8 characters
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         19886
>Category:       bin
>Synopsis:       skey won't work for usernames > 8 characters
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 12 23:20:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Gregory Bond
>Release:        FreeBSD 4.0-STABLE i386
>Organization:
ITG Australia Limited
>Environment:

4-Stable

>Description:

skey will not authenticate usernames longer than 8 characters.

>How-To-Repeat:

adduser "testuser123" and try and use s/key to log in.

>Fix:


Index: skeylogin.c
===================================================================
RCS file: /usr/ncvs/src/lib/libskey/skeylogin.c,v
retrieving revision 1.14
diff -u -r1.14 skeylogin.c
--- skeylogin.c	1998/10/26 13:33:39	1.14
+++ skeylogin.c	2000/07/13 06:05:43
@@ -19,6 +19,8 @@
 #include <time.h>
 #include <errno.h>
 
+#include <utmp.h>
+
 #include "skey.h"
 #include "pathnames.h"
 
@@ -124,7 +126,7 @@
 
 	/* Look up user name in database */
 	len = strlen(name);
-	if( len > 8 ) len = 8;		/*  Added 8/2/91  -  nmh */
+	if( len > UT_NAMESIZE ) len = UT_NAMESIZE;
 	found = 0;
 	while(!feof(mp->keyfile)){
 		recstart = ftell(mp->keyfile);

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message