From owner-freebsd-net@FreeBSD.ORG Fri Sep 30 18:23:28 2005 Return-Path: X-Original-To: net@FreeBSD.org Delivered-To: freebsd-net@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADA2616A41F; Fri, 30 Sep 2005 18:23:28 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02E3243D48; Fri, 30 Sep 2005 18:23:27 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j8UINQ2m049001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 30 Sep 2005 22:23:26 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j8UINQWT049000; Fri, 30 Sep 2005 22:23:26 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 30 Sep 2005 22:23:25 +0400 From: Gleb Smirnoff To: Pawel Jakub Dawidek Message-ID: <20050930182325.GO45345@cell.sick.ru> References: <20050930124000.GA45345@cell.sick.ru> <20050930160302.GJ45345@cell.sick.ru> <20050930181322.GB1768@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20050930181322.GB1768@garage.freebsd.pl> User-Agent: Mutt/1.5.6i Cc: arch@FreeBSD.org, net@FreeBSD.org Subject: Re: [REVIEW/TEST] polling(4) changes X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2005 18:23:28 -0000 On Fri, Sep 30, 2005 at 08:13:22PM +0200, Pawel Jakub Dawidek wrote: P> On Fri, Sep 30, 2005 at 08:03:02PM +0400, Gleb Smirnoff wrote: P> +> On Fri, Sep 30, 2005 at 04:40:00PM +0400, Gleb Smirnoff wrote: P> +> T> [please, follow-up on net@ only] P> +> T> P> +> T> Colleagues, P> +> T> P> +> T> here are some patches for review. P> +> P> +> I have some changes to patch after last compile, and haven't tested them P> +> befire sending patch. Here is an updated one. P> P> BTW. Not compiling in DEVICE_POLLING has any advantages except few bytes P> smaller kernel? P> I wonder if we could drop yet another kernel option and just set P> kern.poll.enable to 0 by default. P> If adding DEVICE_POLLING to the kernel doesn't cost additional locking, etc. P> in network data flow paths (which could lead to performance impact in some P> specific environments) can we just compile the code in always? It adds a stub function call every tick. The function returns almost immediately if no interfaces do polling. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE