From owner-cvs-all Mon Sep 11 22:35:50 2000 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 17B8037B423; Mon, 11 Sep 2000 22:35:48 -0700 (PDT) Received: (from rwatson@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id WAA38687; Mon, 11 Sep 2000 22:35:48 -0700 (PDT) (envelope-from rwatson@FreeBSD.org) Message-Id: <200009120535.WAA38687@freefall.freebsd.org> From: Robert Watson Date: Mon, 11 Sep 2000 22:35:47 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/ufs/ufs ufs_extattr.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG rwatson 2000/09/11 22:35:47 PDT Modified files: sys/ufs/ufs ufs_extattr.c Log: o Variety of extended attribute fixes - In ufs_extattr_enable(), return EEXIST instead of EOPNOTSUPP if the caller tries to configure an attribute name that is already configured - Throughout, add IO_NODELOCKED to VOP_{READ,WRITE} calls to indicate lock status of passed vnode. Apparently not a problem, but worth fixing. - For all writes, make use of IO_SYNC consistent. Really, IO_UNIT and combining of VOP_WRITE's should happen, but I don't have that tested. At least with this, it's consistent usage. (pointed out by: bde) - In ufs_extattr_get(), fixed nested locking of backing vnode (fine due to recursive lock support, but make it more consistent with other code) - In ufs_extattr_get(), clean up return code to set uio_resid more consistently with other pieces of code (worked fine, this is just a cleanup) - Fix ufs_extattr_rm(), which was broken--effectively a nop. - Minor comment and whitespace fixes. Obtained from: TrustedBSD Project Revision Changes Path 1.11 +40 -27 src/sys/ufs/ufs/ufs_extattr.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message