From owner-cvs-all@FreeBSD.ORG  Sun Jul  6 22:41:54 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 72F4637B401; Sun,  6 Jul 2003 22:41:54 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D525343FAF; Sun,  6 Jul 2003 22:41:53 -0700 (PDT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id C03DA2ED445; Sun,  6 Jul 2003 22:41:53 -0700 (PDT)
Date: Sun, 6 Jul 2003 22:41:53 -0700
From: Alfred Perlstein <bright@mu.org>
To: David Xu <davidxu@viatech.com.cn>
Message-ID: <20030707054153.GN72093@elvis.mu.org>
References: <200307070428.h674SNfq092785@repoman.freebsd.org>
	<20030707044204.GM72093@elvis.mu.org>
	<005f01c34442$f9091c40$f001a8c0@davidw2k>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <005f01c34442$f9091c40$f001a8c0@davidw2k>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libpthread/thread thr_attr_get_np.c
	thr_cancel.c thr_getschedparam.c thr_join.c thr_mutex_prioceiling.c
	thr_sigaction.c thr_sigmask.c thr_sigpending.c thr_sigsuspend.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jul 2003 05:41:54 -0000

* David Xu <davidxu@viatech.com.cn> [030706 21:45] wrote:
> 
> > * David Xu <davidxu@FreeBSD.org> [030706 21:28] wrote:
> > > davidxu     2003/07/06 21:28:23 PDT
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     lib/libpthread/thread thr_attr_get_np.c thr_cancel.c 
> > >                           thr_getschedparam.c thr_join.c 
> > >                           thr_mutex_prioceiling.c thr_sigaction.c 
> > >                           thr_sigmask.c thr_sigpending.c 
> > >                           thr_sigsuspend.c 
> > >   Log:
> > >   Avoid accessing user provided parameters in critical region.
> > 
> > Interesting, is this to avoid pagefaults during critical sections
> > inside userspace?
> > 
> Yes.

Sorry to yammer out a bunch of questions out of the blue, but I'm
trying to understand:

Is that completely necessary?  I mean, isn't it likely that these
arguements are paged in since they are parameters that have just
been touched by the process?  What if there's paging pressure and
the stack gets paged out anyway?  Is there something protecting
that from happening?  I mean, I know it would be unpleasant to
fault, but the code should be able to handle this right?

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
 start asking why software is ignoring 30 years of accumulated wisdom.'