From owner-svn-src-all@freebsd.org Sun Apr 8 17:15:20 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D317FF9213B; Sun, 8 Apr 2018 17:15:20 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2B1988524E; Sun, 8 Apr 2018 17:15:19 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w38HFBEC014285; Sun, 8 Apr 2018 10:15:11 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w38HFB4t014284; Sun, 8 Apr 2018 10:15:11 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201804081715.w38HFB4t014284@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r332290 - stable/11/sys/dev/de In-Reply-To: <201804081659.w38GxdFE008124@repo.freebsd.org> To: Brooks Davis Date: Sun, 8 Apr 2018 10:15:11 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Apr 2018 17:15:21 -0000 [ Charset UTF-8 unsupported, converting... ] > Author: brooks > Date: Sun Apr 8 16:59:39 2018 > New Revision: 332290 > URL: https://svnweb.freebsd.org/changeset/base/332290 > > Log: MFC r331737: > GC never enabled support for SIOCGADDRROM and SIOCGCHIPID. > > When de(4) was imported in 1997 the world was not ready for these ioctls. > In over 20 years that hasn't changed so it seems safe to assume their > time will never come. > > Reviewed by: imp, jhb > Approved by: CheriBSD > Sponsored by: DARPA, AFRL > Differential Revision: https://reviews.freebsd.org/D14889 > > Modified: > stable/11/sys/dev/de/if_de.c > stable/11/sys/dev/de/if_devar.h > Directory Properties: > stable/11/ (props changed) > > Modified: stable/11/sys/dev/de/if_de.c > ============================================================================== > --- stable/11/sys/dev/de/if_de.c Sun Apr 8 16:55:28 2018 (r332289) > +++ stable/11/sys/dev/de/if_de.c Sun Apr 8 16:59:39 2018 (r332290) > @@ -4264,18 +4264,6 @@ tulip_ifioctl(struct ifnet * ifp, u_long cmd, caddr_t > break; > } > > -#ifdef SIOCGADDRROM > - case SIOCGADDRROM: { > - error = copyout(sc->tulip_rombuf, ifr_data_get_ptr(ifr), sizeof(sc->tulip_rombuf)); > - break; > - } > -#endif > -#ifdef SIOCGCHIPID > - case SIOCGCHIPID: { > - ifr->ifr_metric = (int) sc->tulip_chipid; > - break; > - } > -#endif > default: { > error = ether_ioctl(ifp, cmd, data); > break; > > Modified: stable/11/sys/dev/de/if_devar.h > ============================================================================== > --- stable/11/sys/dev/de/if_devar.h Sun Apr 8 16:55:28 2018 (r332289) > +++ stable/11/sys/dev/de/if_devar.h Sun Apr 8 16:59:39 2018 (r332290) > @@ -874,11 +874,6 @@ static const struct { > #define TULIP_TXMAP_POSTSYNC(ri, di) \ > _TULIP_MAP_SYNC(ri, di, BUS_DMASYNC_POSTWRITE) > > -#ifdef notyet > -#define SIOCGADDRROM _IOW('i', 240, struct ifreq) /* get 128 bytes of ROM */ > -#define SIOCGCHIPID _IOWR('i', 241, struct ifreq) /* get chipid */ > -#endif > - > #if defined(TULIP_HDR_DATA) > static tulip_softc_t *tulips[TULIP_MAX_DEVICES]; > #endif > > -- Rod Grimes rgrimes@freebsd.org