From owner-freebsd-geom@FreeBSD.ORG  Wed Aug 18 17:10:03 2010
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5A540106564A
	for <freebsd-geom@hub.freebsd.org>;
	Wed, 18 Aug 2010 17:10:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 45FAF8FC08
	for <freebsd-geom@hub.freebsd.org>;
	Wed, 18 Aug 2010 17:10:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7IHA3Pw015254
	for <freebsd-geom@freefall.freebsd.org>; Wed, 18 Aug 2010 17:10:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7IHA3Ww015251;
	Wed, 18 Aug 2010 17:10:03 GMT (envelope-from gnats)
Date: Wed, 18 Aug 2010 17:10:03 GMT
Message-Id: <201008181710.o7IHA3Ww015251@freefall.freebsd.org>
To: freebsd-geom@FreeBSD.org
From: Oliver Fromme <olli@lurza.secnetix.de>
Cc: 
Subject: Re: kern/149762: volume labels with rogue characters
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Oliver Fromme <olli@lurza.secnetix.de>
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2010 17:10:03 -0000

The following reply was made to PR kern/149762; it has been noted by GNATS.

From: Oliver Fromme <olli@lurza.secnetix.de>
To: freebsd-geom@FreeBSD.ORG, bug-followup@FreeBSD.ORG, walter@pelissero.de
Cc:  
Subject: Re: kern/149762: volume labels with rogue characters
Date: Wed, 18 Aug 2010 19:06:26 +0200 (CEST)

 Oliver Fromme wrote:
  >  I have reviewed the patch (the second one from the followup),
  >  and it looks good to me, except for a few minor style(9)
  >  issues, and one type problem:  By default, char is unsigned,
                                               ^^^^^^^^^^^^^^^^^^
  >  so the comparisons p <= ' ' and p > '~' probably don't do
  >  what you expect.
 
 I'm sorry, I meant signed, of course.
 You need to specify "unsigned char" if you want it to be unsigned.
 
 Best regards
    Oliver
 
 -- 
 Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
 Handelsregister: Registergericht Muenchen, HRA 74606,  Geschäftsfuehrung:
 secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün-
 chen, HRB 125758,  Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart
 
 FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd
 
 "C is quirky, flawed, and an enormous success."
         -- Dennis M. Ritchie.