Date: Mon, 18 Jul 2016 04:22:49 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 210608] www/subsonic-standalone: Update to 6.0 and improve port Message-ID: <bug-210608-13-gCNLmEd44f@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-210608-13@https.bugs.freebsd.org/bugzilla/> References: <bug-210608-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210608 --- Comment #17 from Jeremie Le Hen <jlh@FreeBSD.org> --- I started with an empty scratch jail and the port and its dependencies are still being compiled :-). Anyways, from the detailed summary you gave (thanks!), here are my comments: - I would rather leave "-standalone" in ${PORTNAME}; otherwise I think this port will be identified as "subsonic", like the non-standalone version and = this may cause unforeseen problems (like, for instance, I don't know how the upg= rade process will handle this). I can be convinced to use ${PKGNAMESUFFIX}, but please give a good reason. - I'm not super fan of installing the port to ${DATADIR}. I find it weird = to have the .sh there. This is the main reason I ended up installing in ${PREFIX}/${PORTDIRNAME}. But well, I guess it's OK. Nonetheless I am concerned about the upgrade path; have you tested this? - Please make either a compat shim for the options you removed, or a big warning the option has been deprecated, giving the replacement method. -- Jeremie --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210608-13-gCNLmEd44f>