From owner-freebsd-ports-bugs@freebsd.org Mon Jul 18 04:22:49 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A827B9C8E5 for ; Mon, 18 Jul 2016 04:22:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0F1E51D96 for ; Mon, 18 Jul 2016 04:22:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6I4MmPd093380 for ; Mon, 18 Jul 2016 04:22:48 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 210608] www/subsonic-standalone: Update to 6.0 and improve port Date: Mon, 18 Jul 2016 04:22:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: easy, patch, patch-ready X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jlh@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jlh@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 04:22:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210608 --- Comment #17 from Jeremie Le Hen --- I started with an empty scratch jail and the port and its dependencies are still being compiled :-). Anyways, from the detailed summary you gave (thanks!), here are my comments: - I would rather leave "-standalone" in ${PORTNAME}; otherwise I think this port will be identified as "subsonic", like the non-standalone version and = this may cause unforeseen problems (like, for instance, I don't know how the upg= rade process will handle this). I can be convinced to use ${PKGNAMESUFFIX}, but please give a good reason. - I'm not super fan of installing the port to ${DATADIR}. I find it weird = to have the .sh there. This is the main reason I ended up installing in ${PREFIX}/${PORTDIRNAME}. But well, I guess it's OK. Nonetheless I am concerned about the upgrade path; have you tested this? - Please make either a compat shim for the options you removed, or a big warning the option has been deprecated, giving the replacement method. -- Jeremie --=20 You are receiving this mail because: You are on the CC list for the bug.=