From owner-cvs-all Sun Apr 7 23:18:14 2002 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id BE60637B400; Sun, 7 Apr 2002 23:18:10 -0700 (PDT) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.2/8.12.2) with ESMTP id g386HXY9054698; Mon, 8 Apr 2002 08:17:34 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/newfs mkfs.c newfs.c newfs.h In-Reply-To: Your message of "Mon, 08 Apr 2002 15:56:18 +1000." <20020408154911.F5774-100000@gamplex.bde.org> Date: Mon, 08 Apr 2002 08:17:33 +0200 Message-ID: <54697.1018246653@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020408154911.F5774-100000@gamplex.bde.org>, Bruce Evans writes: >On Sun, 7 Apr 2002, Poul-Henning Kamp wrote: > >> phk 2002/04/07 07:57:57 PDT >> >> Modified files: >> sbin/newfs mkfs.c newfs.c newfs.h >> Log: >> bbsize and sbsize cannot ever be trusted from the disklabel, in >> particular as there may not be one. Remove #if 0'ed code which might >> mislead people to think otherwise. > >I use this code unconditionally. bbsize and sbsize from the disklabel >can be trusted in all cases that I know of (if there is a disklabel). > >Please back this out. I don't intend to. newfs will have to learn the new (not yet committed) API just like any other program. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message