Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 03 Apr 2020 18:10:10 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   maintainer-approval requested: [Bug 245156] audio/pulseaudio: parse /dev/sndstat correctly to get device name : [Attachment 213026] Proposed patch (since 516738 revision, v3)
Message-ID:  <bug-245156-6497-C7i2TOkSiL@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-245156-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-245156-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
lightside <lightside@gmx.com> has asked freebsd-gnome mailing list
<gnome@FreeBSD.org> for maintainer-approval:
Bug 245156: audio/pulseaudio: parse /dev/sndstat correctly to get device na=
me
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245156

Attachment 213026: Proposed patch (since 516738 revision, v3)
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D213026&action=3Dedit



--- Comment #16 from lightside <lightside@gmx.com> ---
Created attachment 213026
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D213026&action=
=3Dedit
Proposed patch (since 516738 revision, v3)

Attached patch for third variant, based on comment #15 and Greg V proposal =
on:
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/94a781060e64c=
b871
c0f2d3ee768123dd904f0a8?merge_request_iid=3D277

I also modified output format, based on Henry Hu proposal in attachment
#212838, i.e.
from "pa_snprintf(name, l, "%d - %s", device, k);" to "pa_snprintf(name, l,
"%d: %s", device, k);". But I guess, developers may decide about what to us=
e in
this case.

Thanks for attention.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-245156-6497-C7i2TOkSiL>